Merge lp:~kokoto-java/checkbox/new-QT-home-screen into lp:checkbox
| Status: | Merged |
|---|---|
| Merged at revision: | 1546 |
| Proposed branch: | lp:~kokoto-java/checkbox/new-QT-home-screen |
| Merge into: | lp:checkbox |
| Diff against target: |
381 lines (+223/-30) (has conflicts) 2 files modified
qt/checkbox-qt-head-orig.svg (+163/-0) qt/frontend/qtfront.ui (+60/-30) Contents conflict in qt/frontend/images/checkbox-qt-head.png Text conflict in qt/frontend/qtfront.ui |
| To merge this branch: | bzr merge lp:~kokoto-java/checkbox/new-QT-home-screen |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marc Tardif (community) | 2012-07-09 | Approve on 2012-08-03 | |
|
Review via email:
|
|||
Description of the Change
Redesigned the homescreen of the QT UI.
From:
http://
To:
http://
| George Karavasilev (kokoto-java) wrote : | # |
Ok, that line doesn't count :)
The file that is used is "qt/frontend/
P.S. As far as the redesign goes - it looks more tidy than before (there is NO giant "OK" button and no out of place checkbox), the line (separator) between the TextBox and the checbox+button makes the window look a bit more professional and last, but not least the new banner fits Ambiance (the default theme) so much better :)
- 1485. By George Karavasilev on 2012-07-10
-
Fixed the silly ABBA string bug -_-
- 1486. By George Karavasilev on 2012-07-12
-
Changed the banner. The credits for the new one go to Marin Treselj on Google+ :)
| Marc Tardif (cr3) wrote : | # |
I have shared your redesign with other people and they like what they see! The only nit to pick is that "System Testing" is part of the image whereas the string should be translatable. If you are able to make the string translatable, that would be very much appreciated. Otherwise, if you could just make an extra version of the image available without the string, we could then fix that problem later without butchering your image. Make sense?
| Marc Tardif (cr3) wrote : | # |
@George, any updates on this? This is a very exciting merge request and we just need to push it the last mile. Please let me know if anything is blocking you. Thanks!
| George Karavasilev (kokoto-java) wrote : | # |
@Marc, I *seriously* need to talk to you on IRC about this MR :)
| George Karavasilev (kokoto-java) wrote : | # |
A bit of feedback about the MR:
- "Confirm" as a button label is just wrong. "Continue" sounds much better name for that button. That's a 1 second fix.
- The checkbox "Don't show me this message again" shouldn't start with "Don't", however changing the label to "Show me this message again" would change the behaviour of the home screen, because if the use doesn't check that checkboc he won't be able to see the homescreen again. This is a seperate bug and somebody must change the behaviour of the checkbox and the UI. This is most likely not to be implemented in this MR.
- The banner outline should be killed off (And I'm not sure that's even possible, but then again after my after this MR is merged someone can try playing w/ it and fix it. BTW: that outline is here even know, it is just the current banned is light and the light outline is not that visible)
- Mking the "System Testing" string translatable will be next to impossible with the current banner design (it would require either a banner redesign and it won't be that pretty after it or some incredibly ugly hack in the UI code that will be ... well, incredibly ugly) and to be fair I'm not sure it is that needed, because the titlebar does say "System Testing")
| Marc Tardif (cr3) wrote : | # |
These additional changes could be done independently of this merge request, but I would like to see each point you raise as a bug report. To save some time, you might like to fix the first point since it a 1 second fix.
I would still like to get the original banner produced in Inkscape which should be added to this merge request. If you can't get it, just let me know, I'll review anyways knowing we did a best effort. Either way, also let me know the name of the person who did the banner so that we can give due credit.
Thanks!
- 1487. By George Karavasilev on 2012-08-02
-
Fixed the button label, now it says "Continue" rather then "Confirm". Made the "System Testing" string translatable. Added the orginal banner from Marin Treselj on Google+ in the MR, it is located in "qt/checkbox-
qt-head- orig.svg" :)
| George Karavasilev (kokoto-java) wrote : | # |
@Mark, just updated the MR. Here are the changes:
Fixed the button label, now it says "Continue" rather then "Confirm"
Made the "System Testing" string translatable and redesigned the banner so it fits with the translatable string
Added the orginal banner from Marin Treselj on Google+ in the MR, it is located in "qt/checkbox-
Here is how it looks now:
http://
NOTE: After you merge this I will fill a bug report about the things I've marked as To-Do and hopefully some nice fellah (could be me for all I know :D) will fix them :P
| Marc Tardif (cr3) wrote : | # |
Looks good, thanks so much! I made a few modifications while committing:
1. Changed the pointsize of the "System\nTesting" label to 18 so that other languages have a chance to fit.
2. Added a property to aligh that label right and center which seems to look nicer.
3. Removed the execute bit from qt/checkbox-
4. Renamed it to qt/checkbox-
5. Removed qt/checkbox.svg
| George Karavasilev (kokoto-java) wrote : | # |
Thank you so much for merging this! :)
Next up - main QT UI :)
Thanks for your suggested changes but it's not clear how this redesign is better than the previous Qt UI. Please describe the motivation for your changes and perhaps their source of inspiration. You might also like to document the guidelines the previous Qt UI was not respecting and how your changes fix some of them.
Also, please note that this change doesn't look quite right:
8 - <string>Don't show me this message in the future</string>
9 + <string>Don't show me this message in the ABBA!</string>
Indeed, we don't want to show messages in the ABBA but we preferably don't want to show them in the future.