Code review comment for ~knitzsche/snappy-hwe-snaps/+git/wifi-connect:defaults

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

thanks for pointing this out Roberto

On 06/26/2017 07:09 AM, Roberto Mier Escandón  wrote:
>> After discussion with Konrad, I'll leave the markdown as is since I
>> consistently use code blocks.
>>
>> After discussion with Roberto, I'll leave the name of "Wifiaper" interface as
>> is for consistency with golang interface naming conventions.
>
> A note here about the name of the interface:
>
> https://golang.org/doc/effective_go.html#interface-names says "one-method interfaces are named by the method name plus an -er suffix or similar modification to construct an agent noun". But nothing specific says about interfaces having more than one method. So, golang naming conventions nothing say about this case. (or at least I haven't found anything)
>

« Back to merge proposal