~knitzsche/snappy-hwe-snaps/+git/wifi-connect:defaults

Branch merges

Propose for merging

Merged into ~snappy-hwe-team/snappy-hwe-snaps/+git/wifi-connect:master at revision d8fe23b5e46dd61a32c597d146aa434feb2958cd

Roberto Mier Escandon (community): Approve on 2017-06-29

Konrad Zapałowicz (community): Approve (code) on 2017-06-28

System Enablement Bot: Approve (continuous-integration) on 2017-06-28

Diff: 941 lines (+700/-38)

15 files modified

README.md (+1/-1)
daemon/daemon.go (+66/-6)
daemon/daemon_test.go (+121/-20)
docs/faq.md (+10/-0)
docs/index.md (+24/-0)
docs/installation.md (+121/-0)
docs/integrate.md (+70/-0)
docs/metadata.yaml (+12/-0)
hooks/configure.go (+111/-0)
hooks/configure_test.go (+110/-0)
service/service.go (+14/-6)
snap/snapcraft.yaml (+8/-3)
static/tests/pre-config0.json (+7/-0)
static/tests/pre-config1.json (+5/-0)
wifiap/wifiap.go (+20/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

174a30c... by Kyle Nitzsche on 2017-06-28

SetDefaults now ialso takes a Preconfig - easier testing

4b79f17... by Kyle Nitzsche on 2017-06-27

use const for passphrase min & max length

67d24fc... by Kyle Nitzsche on 2017-06-27

R and K's comments addressed

Inline comments can apparently go in the bit bucket, so manual
responses:

Roberto:
* I changed GetTestClient to ModClient per your suggestion

Konrad:
* I removed PreConfigFile entirely and thereby simplified code relating
* to it
* I added func LoadPreConfig() (*PreConfig, error), and added a unit
* test
* I cannot use wifiap.Operations as a receiver because it is an
* interface, so SetDefaults signature is unchanged, but the code that
* calls it from service.go is indeed simpler
* deleted this unused: func (c *Client) NewConfig() *PreConfig
* I am postponing the title-capitalization-in-docs comments because its
* not done in any of these places, so lets ensure we are on the same
* page:
  * https://docs.ubuntu.com/landscape/en/landscape-managing-computers
  * https://docs.ubuntu.com/maas/2.1/en/
  * https://docs.ubuntu.com/core/en/
  Note: It's not always clear what to capitalize in English titles so
it's common to use lower case

572a8cb... by Kyle Nitzsche on 2017-06-27

PreConfig.PreConfigFile renamed to PreConfigFileExists for clarity

48be044... by Kyle Nitzsche on 2017-06-27

delete NewConfig() (it's no longer used)

bc0d115... by Kyle Nitzsche on 2017-06-27

Roberto's comments addressed

snapGet() is shorter

Changed GetTestClient to ModClient

7c2261a... by Kyle Nitzsche on 2017-06-27

delete commented out code line

f89788c... by Kyle Nitzsche on 2017-06-26

improve SetDefaults() sig. Use "Operations" interface name.

aa64182... by Kyle Nitzsche on 2017-06-23

daemon.SetDefaults(): reuse err

37dddc0... by Kyle Nitzsche on 2017-06-23

remove unneeded daemon.SetPreConfigFile() per review