~knitzsche/snappy-hwe-snaps/+git/wifi-connect:defaults

Last commit made on 2017-06-28
Get this branch:
git clone -b defaults https://git.launchpad.net/~knitzsche/snappy-hwe-snaps/+git/wifi-connect
Only Kyle Nitzsche can upload to this branch. If you are Kyle Nitzsche please log in for upload directions.

Branch merges

Branch information

Recent commits

174a30c... by Kyle Nitzsche on 2017-06-28

SetDefaults now ialso takes a Preconfig - easier testing

4b79f17... by Kyle Nitzsche on 2017-06-27

use const for passphrase min & max length

67d24fc... by Kyle Nitzsche on 2017-06-27

R and K's comments addressed

Inline comments can apparently go in the bit bucket, so manual
responses:

Roberto:
* I changed GetTestClient to ModClient per your suggestion

Konrad:
* I removed PreConfigFile entirely and thereby simplified code relating
* to it
* I added func LoadPreConfig() (*PreConfig, error), and added a unit
* test
* I cannot use wifiap.Operations as a receiver because it is an
* interface, so SetDefaults signature is unchanged, but the code that
* calls it from service.go is indeed simpler
* deleted this unused: func (c *Client) NewConfig() *PreConfig
* I am postponing the title-capitalization-in-docs comments because its
* not done in any of these places, so lets ensure we are on the same
* page:
  * https://docs.ubuntu.com/landscape/en/landscape-managing-computers
  * https://docs.ubuntu.com/maas/2.1/en/
  * https://docs.ubuntu.com/core/en/
  Note: It's not always clear what to capitalize in English titles so
it's common to use lower case

572a8cb... by Kyle Nitzsche on 2017-06-27

PreConfig.PreConfigFile renamed to PreConfigFileExists for clarity

48be044... by Kyle Nitzsche on 2017-06-27

delete NewConfig() (it's no longer used)

bc0d115... by Kyle Nitzsche on 2017-06-27

Roberto's comments addressed

snapGet() is shorter

Changed GetTestClient to ModClient

7c2261a... by Kyle Nitzsche on 2017-06-27

delete commented out code line

f89788c... by Kyle Nitzsche on 2017-06-26

improve SetDefaults() sig. Use "Operations" interface name.

aa64182... by Kyle Nitzsche on 2017-06-23

daemon.SetDefaults(): reuse err

37dddc0... by Kyle Nitzsche on 2017-06-23

remove unneeded daemon.SetPreConfigFile() per review