GTG

Code review comment for lp:~kmhpfoss/gtg/bug-fix-

Revision history for this message
Izidor MatuĊĦov (izidor) wrote :

Hi codee,

I am going to nitpick about your code, don't take it personally :)

8 +
9 + ###################################Newly added bug fixes#############################
10 +
11 + self.duedate_widget = self.builder.get_object("duedate_entry")
12 + self.startdate_widget = self.builder.get_object("startdate_entry")
13 + self.closeddate_widget = self.builder.get_object("closeddate_entry")
14 +
15 + #############################End this section - go to next###########################

Why did you move that block of the code and add extra comments around it? It is not needed, put it please back.

As I was playing with your solution, I found out that we were missing refresh_editor() call after the date_changed() was called. You can solve this bug by just one additional line. Call refresh_editor() method within date_changed().

In the end it would result in much more cleaner and simplier solution for this bug -- only one line change! If you have any questions, feel free to ask; either on IRC or here in comments.

review: Needs Fixing (code, run)

« Back to merge proposal