Merge lp:~kmhpfoss/gtg/bug-fix- into lp:~gtg/gtg/old-trunk

[Codee]

Fixed the bug related to changing date manually mentioned in https://bugs.launchpad.net/gtg/+bug/1047753
Included event handlers for entry focus lost event and enter key pressed event

[Izidor Matušov (izidor)]

Hi codee,

I am going to nitpick about your code, don't take it personally :)

8 +
9 + ###################################Newly added bug fixes#############################
10 +
11 + self.duedate_widget = self.builder.get_object("duedate_entry")
12 + self.startdate_widget = self.builder.get_object("startdate_entry")
13 + self.closeddate_widget = self.builder.get_object("closeddate_entry")
14 +
15 + #############################End this section - go to next###########################

Why did you move that block of the code and add extra comments around it? It is not needed, put it please back.

As I was playing with your solution, I found out that we were missing refresh_editor() call after the date_changed() was called. You can solve this bug by just one additional line. Call refresh_editor() method within date_changed().

In the end it would result in much more cleaner and simplier solution for this bug -- only one line change! If you have any questions, feel free to ask; either on IRC or here in comments.

review: Needs Fixing (code, run)

[Codee (kmhpfoss)]

Hi Izidor,

I've done the necessary code changes mentioned above.

And I've been assigned to this bug fix(#1047753), but I can't commit it as I don't have committer rights.

[Izidor Matušov (izidor)]

Codee: please remove date_changed_manually and registering callbacks for it. You don't need that :)

review: Needs Fixing (code)

[Izidor Matušov (izidor)]

You should call self.refresh_editor() only then when the date is valid. Otherwise, you can't delete any character of the date and writing the date manually is not possible. Please, fix it.

review: Needs Fixing (code, run)

[Izidor Matušov (izidor)]

Thank you for your fix, it looks great now.

review: Approve (code, run)

=== modified file 'GTG/gtk/editor/editor.py'
--- GTG/gtk/editor/editor.py	2012-11-25 19:19:44 +0000
+++ GTG/gtk/editor/editor.py	2012-11-27 16:59:29 +0000
@@ -68,6 +68,7 @@
         self.subtask_button.set_tooltip_text(GnomeConfig.SUBTASK_TOOLTIP)
         self.inserttag_button = self.builder.get_object("inserttag")
         self.inserttag_button.set_tooltip_text(GnomeConfig.TAG_TOOLTIP)
+
         #Create our dictionary and connect it
         dic = {
                 "mark_as_done_clicked": self.change_status,
@@ -371,11 +372,15 @@
                 self.task.set_due_date(datetoset)
             elif data == "closed":
                 self.task.set_closed_date(datetoset)
+            self.refresh_editor()
+
         else:
             #We should write in red in the entry if the date is not valid
             widget.modify_text(gtk.STATE_NORMAL, gtk.gdk.color_parse("#F00"))
             widget.modify_base(gtk.STATE_NORMAL, gtk.gdk.color_parse("#F88"))
 
+
+
     def on_date_pressed(self, widget, date_kind):
         """Called when a date-changing button is clicked."""
         if date_kind == GTGCalendar.DATE_KIND_DUE: