Code review comment for ~kissiel/plainbox-provider-checkbox:poweroff-autoresume

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> I'd add package.name == 'x-terminal-emulator' as a job requirement and call x
> -terminal-emulator from pm_test, this way we're not stuck with gnome-term.
>
> But drop the packaging meta-data, it will indeed have undesired side-effect
> for server-cert packaging.

x-terminal-emulator is a virtual package, which doesn't get reported by package, so I decided to go with 'executable' resource instead.

This, OTOH, requires unreleased version of plainbox-provider-resource, as x-terminal-emulator is a symlink. More info: https://bugs.launchpad.net/plainbox-provider-resource/+bug/1710172

Everything works nicely provided with ppr supplied from master.

review: Needs Resubmitting

« Back to merge proposal