Code review comment for ~kissiel/plainbox-provider-checkbox:respawn-after-pmtest-reboots

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

I'm trying to test only the job id:
com.canonical.certification::power-management/suspend_30_cycles_with_reboots

To be sure to save the respawn command in the session share, I've only added flags: noreturn to this job.

But executing the following makes checkbox-cli to crash:

$ checkbox-cli run .*with_reboots
[...]
--------------[ Running job 5 / 5. Estimated time left: 1:30:00 ]---------------
--------------[ power-management/suspend_30_cycles_with_reboots ]---------------
ID: com.canonical.certification::power-management/suspend_30_cycles_with_reboots
Category: com.canonical.plainbox::stress
Waiting for the system to shut down or reboot...

                        Application Malfunction Detected

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/guacamole/core.py", line 248, in eat
    return self._dispatch()
  File "/usr/lib/python3/dist-packages/guacamole/core.py", line 298, in _dispatch
    result = ingredient.dispatch(self.context)
  File "/usr/lib/python3/dist-packages/guacamole/ingredients/cmdtree.py", line 152, in dispatch
    return self._dispatch(context, 0)
  File "/usr/lib/python3/dist-packages/guacamole/ingredients/cmdtree.py", line 179, in _dispatch
    return self._dispatch_None(context, level, retval, command)
  File "/usr/lib/python3/dist-packages/guacamole/ingredients/cmdtree.py", line 208, in _dispatch_None
    return self._dispatch(context, level + 1)
  File "/usr/lib/python3/dist-packages/guacamole/ingredients/cmdtree.py", line 165, in _dispatch
    retval = command.invoked(context)
  File "/home/sylvain/lp/checkbox-ng/checkbox_ng/launcher/subcommands.py", line 852, in invoked
    self.run_matching_jobs(selection)
  File "/home/sylvain/lp/checkbox-ng/checkbox_ng/launcher/subcommands.py", line 876, in run_matching_jobs
    self._run_jobs(self.sa.get_dynamic_todo_list())
  File "/home/sylvain/lp/checkbox-ng/checkbox_ng/launcher/stages.py", line 219, in _run_jobs
    job, self._get_ui_for_job(job))
  File "/home/sylvain/lp/checkbox-ng/checkbox_ng/launcher/stages.py", line 112, in _run_single_job_with_ui_loop
    result_builder = self.sa.run_job(job.id, ui, False)
  File "/home/sylvain/lp/plainbox/plainbox/impl/decorators.py", line 142, in wrapper
    raise exc
  File "/home/sylvain/lp/plainbox/plainbox/impl/decorators.py", line 136, in wrapper
    return func(*args, **kwargs)
  File "/home/sylvain/lp/plainbox/plainbox/impl/session/assistant.py", line 1295, in run_job
    self.get_session_id()))
TypeError: 'NoneType' object is not callable

  Please report a bug including the information from the paragraph above. To
  report the bug visit https://bugs.launchpad.net/checkbox-ng/+filebug

  We are sorry for the inconvenience!

review: Needs Fixing

« Back to merge proposal