Merge lp:~kissiel/checkbox/fix-1397109 into lp:checkbox
Status: | Rejected |
---|---|
Rejected by: | Maciej Kisielewski |
Proposed branch: | lp:~kissiel/checkbox/fix-1397109 |
Merge into: | lp:checkbox |
Diff against target: |
202 lines (+122/-4) 3 files modified
checkbox-touch/components/CheckboxTouchApplication.qml (+14/-1) checkbox-touch/main.qml (+54/-2) checkbox-touch/py/checkbox_touch.py (+54/-1) |
To merge this branch: | bzr merge lp:~kissiel/checkbox/fix-1397109 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Needs Information | ||
Review via email: mp+243503@code.launchpad.net |
Description of the change
This MR brings garbage collecting of old session storage.
57d9d66 checkbox-touch: make exporting of results mark session as 'submitted'
1e65a00 checkbox-touch: add garbage collection of old session storage on start-up
10c39de checkbox-touch: add removal of 'bootstrapping' flag
Unmerged revisions
- 3521. By Maciej Kisielewski
-
checkbox-touch: fix re-removal of session when doing GC
This patch makes checkbox-touch remove garbage collected sessions only once.
The problem with re-removal manifested when session had more than one flag set
(and more than one flag was matching to-be-removed flags)Signed-off-by: Maciej Kisielewski <email address hidden>
- 3520. By Maciej Kisielewski
-
checkbox-touch: file header date bumps
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3519. By Maciej Kisielewski
-
checkbox-touch: qml changes for new session garbage collection
This patch changes how session garbage collection is run in checkbox-touch.
This patch includes changes to qml side of things.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3518. By Maciej Kisielewski
-
checkbox-touch: new way of doing session garbage collection
This patch changes how session garbage collection is run in checkbox-touch.
This patch includes changes to python side of things.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3517. By Maciej Kisielewski
-
checkbox-touch: add flags parameter to python interface
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3516. By Maciej Kisielewski
-
checkbox-touch: ask user if they want to run session storage clearing
This patch makes CBT show dialog when stale sesssions are found in the
filesystem.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3515. By Maciej Kisielewski
-
checkbox-touch: fixes after Zygmunt's review
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3514. By Maciej Kisielewski
-
checkbox-touch: make exporting of results mark session as 'submitted'
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3513. By Maciej Kisielewski
-
checkbox-touch: add garbage collection of old session storage on start-up
This patch makes Checkbox Touch remove old session storage when launching the
App.Fixes: https:/
/bugs.launchpad .net/checkbox- touch/+ bug/1397109
Signed-off-by: Maciej Kisielewski <email address hidden> - 3512. By Maciej Kisielewski
-
checkbox-touch: add removal of 'bootstrapping' flag
This patch makes Checkbox Touch remove 'bootstrapping' flag once user selects
test to run.
10:24 < kissiel> zyga, https:/ /code.launchpad .net/~kissiel/ checkbox/ fix-1397109/ +merge/ 243503 :)
10:25 <@zyga> kissiel: hmm, interesting
10:26 <@zyga> kissiel: I think it might be useful to keep those around indefinitely, I would certainly not remove them without first informing the
user or let them choose
10:26 <@zyga> kissiel: the code itself looks okay
10:26 <@zyga> kissiel: load_checkpoint can raise exceptions
10:26 <@zyga> kissiel: IIRC
10:27 <@zyga> kissiel: I'd move the try/catch so that it covers only the .peek() call
10:27 <@zyga> kissiel: and move the garbage_flags set outside the loop
10:27 <@zyga> kissiel: intersection can be *probably* spelled as & for sets
10:27 <@zyga> kissiel: you may want to remove stuff you cannot peek either
10:28 < kissiel> zyga, I thought of that
10:28 < kissiel> zyga, but this would mean, that broken sessions are lost
10:28 < kissiel> zyga, and we/some1 might want to recover those
10:29 <@zyga> kissiel: yes, that's a good point, though some of those sessions are not broken (incompatible job error)
10:29 <@zyga> kissiel: just no longer resumable
10:29 <@zyga> ...
10:29 <@zyga> though
10:29 <@zyga> I'm wrong
10:29 <@zyga> peek doens't have that
10:29 <@zyga> only stuff like broken json/zip can kill peek
10:30 <@zyga> kissiel: oh, and missing i18n :D
10:30 <@zyga> kissiel: let's iterate and we'll se
10:30 <@zyga> see
10:30 < kissiel> zyga, cool, tahnks