Merge lp:~kissiel/checkbox/fix-1397109-garbage-collection into lp:checkbox
Status: | Rejected |
---|---|
Rejected by: | Maciej Kisielewski |
Proposed branch: | lp:~kissiel/checkbox/fix-1397109-garbage-collection |
Merge into: | lp:checkbox |
Diff against target: |
318 lines (+190/-11) 5 files modified
checkbox-touch/checkbox-touch.qml (+58/-1) checkbox-touch/components/CheckboxTouchApplication.qml (+12/-0) checkbox-touch/py/checkbox_touch.py (+53/-0) checkbox-touch/tests/autopilot/checkbox_touch/__init__.py (+20/-0) checkbox-touch/tests/autopilot/checkbox_touch/test_checkbox_touch.py (+47/-10) |
To merge this branch: | bzr merge lp:~kissiel/checkbox/fix-1397109-garbage-collection |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Checkbox Developers | Pending | ||
Review via email: mp+260564@code.launchpad.net |
Description of the change
This MR brings old and forgotten branch of session garbage collection in Checkbox-Touch.
dec9897 checkbox-touch: add removal of 'bootstrapping' flag
2f1c137 checkbox-touch: add session_
cf8d3ba checkbox-touch: make exporting of results mark session as 'submitted'
ead21d9 checkbox-touch: make garbage collection a two step process
10ea1ba checkbox-touch: add garbage collection api to CBT app component
4752fca checkbox-touch: run garbage collection when CBT starts
db81a46 checkbox-
fca9857 checkbox-
Unmerged revisions
- 3817. By Maciej Kisielewski
-
checkbox-
touch:autopilot : add tests for session garbage collection This patch adds three tests for the session garbage collection functionality:
- check if the dialog is shown
- check if 'do not remove' doesn't remove
- check if 'remove all' actually removes allThe latter two tests only check 'for self symptoms', i.e. after removal the
test only checks if the dialog proposing removal is no longer shown. And for
the one that doesn't remove it checks if the dialog still pops up.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3816. By Maciej Kisielewski
-
checkbox-
touch:autopilot : move select_ two_tests_ and_quit to base This patch moves the function that selects two tests and quits (the setting up
function for some tests) to the ClickAppTestCase base.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3815. By Maciej Kisielewski
-
checkbox-touch: run garbage collection when CBT starts
This patch makes checkbox-touch run the garbage collection step each time the
application starts.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3814. By Maciej Kisielewski
-
checkbox-touch: add garbage collection api to CBT app component
This patch adds necessary functions to CheckboxTouchAp
plication component that
forward calls to python.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3813. By Maciej Kisielewski
-
checkbox-touch: make garbage collection a two step process
This patch adds function that checks if there are collection candidates and
saves them in CheckboxTouchApplication state. This lets clients prompt for
confirmation before removing them.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3812. By Maciej Kisielewski
-
checkbox-touch: make exporting of results mark session as 'submitted'
Signed-off-by: Maciej Kisielewski <email address hidden>
- 3811. By Maciej Kisielewski
-
checkbox-touch: add session_
garbage_ collect function This patch adds the backend function that looks for old and useless sessions
and removes them.Signed-off-by: Maciej Kisielewski <email address hidden>
- 3810. By Maciej Kisielewski
-
checkbox-touch: add removal of 'bootstrapping' flag
This patch makes Checkbox Touch remove 'bootstrapping' flag once user selects
test to run.Signed-off-by: Maciej Kisielewski <email address hidden>
<spineau> kissiel: but I got a situation with 3 red buttons and no subtotals per flags (which could be super nice)
<spineau> kissiel: So I'm wondering if we could instead list them with checkboxes and have buttons like [remove selected sessions] and a [cancel] to just ignore the request for cleanup
<kissiel> spineau, yep, probably :)
<spineau> kissiel: that would leave only 1 red element which is less scary :)
<kissiel> haha :)
<kissiel> spineau, in that case I think I'll use ordinary listview
<spineau> kissiel: still in the popup or a new page?
<kissiel> spineau, I think popup looks better
<spineau> kissiel: +1