Code review comment for lp:~kirkland/maas/1342292

Revision history for this message
Scott Moser (smoser) wrote :

Is there a reason you decided to break if 'echo' is /usr/bin ?
you're explicitly calling the program 'echo' rather than the sh builtin.

less escaping is done by:
 curtin in-target -- sh -c 'echo "$@" > /etc/apt/apt.conf.d/99translations' -- 'Acquire::Languages "none";'

that said, i don't really think this is the right place to work around a squid (or external internet connection) and I really think its not even going to sufficiently work around the issue. It just reduces the number of network connections, possibly reducing failure percentage.

« Back to merge proposal