Merge lp:~kirkland/maas/1342292 into lp:~maas-committers/maas/trunk

[Dustin Kirkland ]

[Scott Moser (smoser)]

Is there a reason you decided to break if 'echo' is /usr/bin ?
you're explicitly calling the program 'echo' rather than the sh builtin.

less escaping is done by:
 curtin in-target -- sh -c 'echo "$@" > /etc/apt/apt.conf.d/99translations' -- 'Acquire::Languages "none";'

that said, i don't really think this is the right place to work around a squid (or external internet connection) and I really think its not even going to sufficiently work around the issue. It just reduces the number of network connections, possibly reducing failure percentage.

[Dustin Kirkland  (kirkland)]

On Tue, Jul 15, 2014 at 2:28 PM, Scott Moser <email address hidden> wrote:
> Is there a reason you decided to break if 'echo' is /usr/bin ?
> you're explicitly calling the program 'echo' rather than the sh builtin.
>
> less escaping is done by:
> curtin in-target -- sh -c 'echo "$@" > /etc/apt/apt.conf.d/99translations' -- 'Acquire::Languages "none";'

No reason. I copied some code I found elsewhere to accomplish this.
That's just what was there. And it worked.

> that said, i don't really think this is the right place to work around a squid (or external internet connection) and I really think its not even going to sufficiently work around the issue. It just reduces the number of network connections, possibly reducing failure percentage.

Agreed, this is a horrible place to put this. However, an SE and I
worked 8 hours through the night (Midnight until 8am), trying to
triage and solve this problem before we stumbled into the customer
environment (bleary eyed), and delivered the demo.

All nodes, and the entire environment, is completely unusable and
unworkable until this is disabled.

[Julian Edwards (julian-edwards)]

I'm wary of landing a hack like this too.

What is the ramification of not including translations in Curtin? Is anything
likely to be relying on those?

[Dustin Kirkland  (kirkland)]

That's fine. Close it if you like. I don't take offense. It is
clearly a hack.

I just hope Google ranks this high enough when people are searching
for these symptoms so that people know how to hack around this. This
has hit us HARD in the field, multiple times now.

:-Dustin

On Tue, Jul 15, 2014 at 7:42 PM, Julian Edwards
<email address hidden> wrote:
> I'm wary of landing a hack like this too.
>
> What is the ramification of not including translations in Curtin? Is anything
> likely to be relying on those?
>
> --
> https://code.launchpad.net/~kirkland/maas/1342292/+merge/226900
> You are the owner of lp:~kirkland/maas/1342292.

[Julian Edwards (julian-edwards)]

Right, the underlying cause is apt, and there's a duped bug of the original for this branch. I'll reject the MP now.

Unmerged revisions

2561. By Dustin Kirkland  on 2014-07-15

disable acquiring translations in user data, for machines brought up by curtin

=== modified file 'contrib/preseeds_v2/curtin_userdata'
--- contrib/preseeds_v2/curtin_userdata	2014-04-25 18:03:38 +0000
+++ contrib/preseeds_v2/curtin_userdata	2014-07-15 19:18:00 +0000
@@ -14,6 +14,7 @@
   driver_04_load: ["sh", "-c", "depmod && modprobe {{driver['module']}}"]
 {{endif}}
 late_commands:
+  lang: curtin in-target -- sh -c "/bin/echo 'Acquire::Languages \"none\";' > /etc/apt/apt.conf.d/99translations"
   maas: [wget, '--no-proxy', '{{node_disable_pxe_url|escape.shell}}', '--post-data', '{{node_disable_pxe_data|escape.shell}}', '-O', '/dev/null']
 {{if third_party_drivers and driver}}
   driver_00_key_get: curtin in-target -- sh -c "/bin/echo -en '{{key_string}}' > /tmp/maas-{{driver['package']}}.gpg"