Merge lp:~kfogel/launchpad/old-1.6-ml-archiver-ui into lp:launchpad
Proposed by
Karl Fogel
Status: | Merged |
---|---|
Approved by: | Barry Warsaw |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~kfogel/launchpad/old-1.6-ml-archiver-ui |
Merge into: | lp:launchpad |
Diff against target: | 224 lines |
To merge this branch: | bzr merge lp:~kfogel/launchpad/old-1.6-ml-archiver-ui |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Barry Warsaw (community) | code | Approve | |
Martin Albisetti (community) | ui | Approve | |
Review via email: mp+6001@code.launchpad.net |
To post a comment you must log in.
Make some basic improvements to our mailing list archives user interface.
(This is the "low-hanging fruit" part of bug #375557.)
Summary:
--------
When we switched to MHonArc for mailing list archives, the archive chronological and multi-page),
pages became very Web 1.0, looking unlike the rest of Launchpad and
having various usability problems: all the messages in chronological
order on one page (should be reverse-
no indication of what team the mailing list is for, etc.
This branch just brings us back to roughly where we were with
Pipermail on lists.canonical.com / lists.ubuntu.com. It does not
address everything in bug #375557 (which describes many further
improvements we could make to our mailing list archives).
This branch makes the following changes to the mailing list archives:
- Use multi-page indexes, so large archives don't swamp browsers. default- gray.
- Sort messages in reverse chronological order.
- Show the date next to each message on an index page.
- Show the mailing list's name, and link back to the team.
- Give pages a white background, instead of browser-
- Put Launchpad logo in upper left corner.
Proposed fix:
-------------
Create a Launchpad-wide MHonArc control file, to customize the
appearance of mailing list archive pages (both the indexes and the
individual messages). Discussed with Barry and Kiko.
Pre-implementation notes: ------- ------- ----
-------
Barry and I talked a lot. I don't think any issues came up that
need mentioning here. We knew we were aiming for the low-hanging
fruit, and that's what we got.
Implementation details: ------- ------- --
-------
Code changes:
* lib/canonical/ launchpad/ mailman/ monkeypatches/ lp-mhonarc- common. mrc:
New rc file, controls MHonArc behavior.
* lib/canonical/ launchpad/ mailman/ monkeypatches/ __init_ _.py EXTERNAL_ ARCHIVER to define the
(monkey_patch): Add flags to PUBLIC_
mailing list name and point MHonArc to the common rc file. Copy the
rc file to the correct location.
Along the way, I discovered that we were not really set up for testing launchpad. dev", and made two branches to fix that:
changes to "lists.
https:/ /code.edge. launchpad. net/~kfogel/ launchpad/ lists-in- hosts /code.edge. launchpad. net/~kfogel/ launchpad/ lists-testable
https:/
The first has passed EC2 tests and been submitted to PQM. The
second is (in theory) done, but not yet tested.
Tests:
------
Er, see "Demo and Q/A".
Demo and Q/A:
-------------
* Start launchpad.dev with 'make run_all'.
* Log in to launchpad.dev as "<email address hidden>" (this test user
should already exist, and have the appropriate administrative
privileges).
* Create a new team 'mltest'.
* Create a mailing list for that team.
* Approve the mailing list (at http:// launchpad. dev/+mailinglis ts).
* Inject the sample data, which you get from here:
http:// launchpadlibrar ian.net/ 26091302/ lp-ml-test- data.tar. gz
Untar it, cd into the resultant lp-ml-test-data/ directory, and
run "./inject.sh" (while launchpad.dev is running, of course).
There are 999 messages in the data. They're originally from the
...