Code review comment for lp:~kfogel/launchpad/old-1.6-ml-archiver-ui

Revision history for this message
Karl Fogel (kfogel) wrote :

> The only comment I have, is that the sender and the date should be somehow
> visually distinct (looking at: http://www.red-bean.com/kfogel/ml-archiver-ui-
> screenshots/new-ml-archives-by-thread-top.png), maybe the sender could be in
> bold?

Done, for the thread index only (using bold didn't look so good for
the date index, so I didn't do it there). On the thread index, it
is a big improvement.

> Also, maybe the date should be YYYY-MM-DD instead of YYYY/MM/DD, as using
> slashes usually means it's formatted.

That turns out to be a bit tricky, due to the way MHonArc works. I'm
not even sure it can be done without modifying MHonArc itself, which
so far we've managed to avoid. Leaving as YYYY/MM/DD for now.

Thanks for the review!

« Back to merge proposal