Code review comment for lp:~ken-vandine/ubuntu-system-settings/rtm-14.09_rotation_lock_string

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Yes, we did say that. The rotation indicator just landed in the rtm images which uses the string "Rotation Lock", not matching settings. The design spec changed the wording for settings a while ago, but no bug was filed. The indicator isn't translated yet at all, so we need to decide if we want to keep settings as is having a string that has been translated which doesn't match the indicator. I'm more concerned about the new string introduced by the indicator, which isn't translated. That string shows whenever you pull down the indicators. In settings we only see it when you launch settings. I'd actually vote to change the string in the indicator so we can benefit from the already translated string for now.

« Back to merge proposal