Merge lp:~ken-vandine/ubuntu-system-settings/rtm-14.09_rotation_lock_string into lp:ubuntu-system-settings/rtm-14.09
| Status: | Merged |
|---|---|
| Approved by: | Ken VanDine on 2014-12-16 |
| Approved revision: | 933 |
| Merged at revision: | 953 |
| Proposed branch: | lp:~ken-vandine/ubuntu-system-settings/rtm-14.09_rotation_lock_string |
| Merge into: | lp:ubuntu-system-settings/rtm-14.09 |
| Diff against target: |
11 lines (+1/-1) 1 file modified
plugins/orientation-lock/orientation-lock.settings (+1/-1) |
| To merge this branch: | bzr merge lp:~ken-vandine/ubuntu-system-settings/rtm-14.09_rotation_lock_string |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve on 2014-12-12 | |
| Sebastien Bacher (community) | 2014-11-03 | Approve on 2014-12-08 | |
|
Review via email:
|
|||
Commit Message
[orientation] String change to Rotation Lock
Description of the Change
[orientation] String change to Rotation Lock
| Ken VanDine (ken-vandine) wrote : | # |
Yes, we did say that. The rotation indicator just landed in the rtm images which uses the string "Rotation Lock", not matching settings. The design spec changed the wording for settings a while ago, but no bug was filed. The indicator isn't translated yet at all, so we need to decide if we want to keep settings as is having a string that has been translated which doesn't match the indicator. I'm more concerned about the new string introduced by the indicator, which isn't translated. That string shows whenever you pull down the indicators. In settings we only see it when you launch settings. I'd actually vote to change the string in the indicator so we can benefit from the already translated string for now.
| Sebastien Bacher (seb128) wrote : | # |
there are more chance than somebody start the settings than use the indicator, especially than the indicator is not displaying an icon by default (it's in the list when you pulldown but it's less discoverable this way)
- 933. By Ken VanDine on 2014-11-18
-
merged from parent
| Sebastien Bacher (seb128) wrote : | # |
Ok, we need to organize a langpack update after that landing/before image promotion though, otherwise the string is going to show untranslated for users
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:933
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
Thanks but we said we wouldn't change strings in rtm anymore no?