Mir

Code review comment for lp:~kdub/mir/client-resize-logic

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good overall.

55 + lk.unlock();
56 + server_requests->free_buffer(it->first);
57 + server_requests->allocate_buffer(size, format, usage);
58 + lk.lock();

I am bit wary of unlocking to perform the reallocation, as, in theory at least, it could allow other threads to come and mess up the state. Not sure if this could happen in practice in this case, but it would be good to know.

review: Approve

« Back to merge proposal