Merge lp:~kdub/mir/client-resize-logic into lp:mir
Status: | Merged |
---|---|
Approved by: | Kevin DuBois |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2878 |
Proposed branch: | lp:~kdub/mir/client-resize-logic |
Merge into: | lp:mir |
Diff against target: |
251 lines (+113/-14) 3 files modified
src/client/buffer_vault.cpp (+26/-6) src/client/buffer_vault.h (+3/-1) tests/unit-tests/client/test_buffer_vault.cpp (+84/-7) |
To merge this branch: | bzr merge lp:~kdub/mir/client-resize-logic |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Alexandros Frantzis (community) | Approve | ||
Chris Halse Rogers | Approve | ||
Review via email: mp+268269@code.launchpad.net |
Commit message
client: add logic to free and allocate buffers of the proper size after a buffer size change.
Description of the change
client: add logic to free and allocate buffers of the proper size after a buffer size change.
There's a bit of plumbing to pass the resize messages to the stream that goes along with this; but its dependent on other yet-unlanded branches.
I tried a few places in the buffer lifecycle to free and allocate. Between the compositor release and the client usage is where we currently do this for exchange-semantics, and this place is the analogous place on the client side. Its a good place to avoid spamming the server with allocation and free requests when rapid resizing occurs.
FAILED: Continuous integration, rev:2848 jenkins. qa.ubuntu. com/job/ mir-ci/ 4591/ jenkins. qa.ubuntu. com/job/ mir-android- vivid-i386- build/3555 s-jenkins. ubuntu- ci:8080/ job/mir- clang-ts- wily-amd64- build/417/ console jenkins. qa.ubuntu. com/job/ mir-clang- wily-amd64- build/1089/ console jenkins. qa.ubuntu. com/job/ mir-mediumtests -vivid- touch/3503/ console jenkins. qa.ubuntu. com/job/ mir-wily- amd64-ci/ 740/console jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- vivid-armhf/ 3503 jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- vivid-armhf/ 3503/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ mir-mediumtests -runner- mako/6280/ console s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 22631
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
deb: http://
FAILURE: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/mir- ci/4591/ rebuild
http://