Code review comment for lp:~kamstrup/unity-lens-applications/ratings-query

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

> 455 + public Database () throws GLib.IOError;
> you're throwing GFileError, so either "throws FileError" or just "throws
> Error".

Fixed to FileError in vapi. libdb raises values coinciding with the unix errnos, which also is the purpose of FileError.

> 180 + ratings.query (pkginfo.package_name, out result);
> perhaps it'd better to enclose it in an "if" considering it returns bool

Done

> 362 + out_result->pkgname = pkgname;
> a bit dangerous, but as long as it's not really used...

Removed the pkgname member from the struct as it was unused anyway - a relic from an alternative idea I pursued but abandoned.

Thanks!

« Back to merge proposal