Merge lp:~kamstrup/unity-lens-applications/ratings-query into lp:unity-lens-applications

[Mikkel Kamstrup Erlandsen]

Implement support for the Ratings filter.

We share a Berkely DB with the Software Center with the Ratings data in. The db is in single-write-multiple-reader mode, so we can safely read it while s-c updates it (which I also verified manually). I took care to have gracefull fallback when the DB is not there or can not be opened for some reason.

Also adds a configure check for xapian.h now that we are here.

ALMOST forgot to add: This branch relies on the DB generated by this branch lp:~mvo/software-center/review-stats-as-dbm-for-unity-with-best-regards to make filtering work. But it's a good test to try without it, as we should have graceful fallback.

[lp:~kamstrup/unity-lens-applications/ratings-query]

248. By Mikkel Kamstrup Erlandsen on 2011-09-22

Set the UnityRatingsResult.pkgname on successful query

249. By Mikkel Kamstrup Erlandsen on 2011-09-22

Remove some redundant requirements from autogen.sh that I added in a frantic panic to resolve some autofoo issues

[Michal Hruby (mhr3)]

Looks nice! I didn't check out the SC branch, so didn't test it fully, but at least I tested the db-not-there case.

Just a couple minor things:

455 + public Database () throws GLib.IOError;
you're throwing GFileError, so either "throws FileError" or just "throws Error".

180 + ratings.query (pkginfo.package_name, out result);
perhaps it'd better to enclose it in an "if" considering it returns bool

362 + out_result->pkgname = pkgname;
a bit dangerous, but as long as it's not really used...

But all in all, approve! :)

review: Approve

[lp:~kamstrup/unity-lens-applications/ratings-query]

250. By Mikkel Kamstrup Erlandsen on 2011-09-23

Make error checking and error reporting better in unity_ratings_database_query()

251. By Mikkel Kamstrup Erlandsen on 2011-09-23

The UnityRatingsDatabase throws a UNIX FileError and not an IOError. Thanks Michal!

252. By Mikkel Kamstrup Erlandsen on 2011-09-23

Use the bool return value from Unity.Ratings.Database.query() to check when to apply the filter

253. By Mikkel Kamstrup Erlandsen on 2011-09-23

Remove the dubiously mem-managed pkgname member from UnityRatingsResult struct. It was unused anyway. Thanks Michal!

[Mikkel Kamstrup Erlandsen (kamstrup)]

> 455 + public Database () throws GLib.IOError;
> you're throwing GFileError, so either "throws FileError" or just "throws
> Error".

Fixed to FileError in vapi. libdb raises values coinciding with the unix errnos, which also is the purpose of FileError.

> 180 + ratings.query (pkginfo.package_name, out result);
> perhaps it'd better to enclose it in an "if" considering it returns bool

Done

> 362 + out_result->pkgname = pkgname;
> a bit dangerous, but as long as it's not really used...

Removed the pkgname member from the struct as it was unused anyway - a relic from an alternative idea I pursued but abandoned.

Thanks!