Code review comment for ~juliank/grub/+git/ubuntu:resilient-boot

Revision history for this message
Steve Langasek (vorlon) wrote :

I see that you commented in the spec that you were moving the invocation of multiple targets into a wrapper script instead of modifying the C code. FTR this comment did not result in any notifications to me.

The problem with doing this in a wrapper script, and why I originally insisted on this being done in grub-install, is that grub-install is also the tool that on EFI systems populates the BootXXXX and BootOrder nvram variables. If we are not passing an ordered list of target devices to grub-install, then it does not know what to do with the nvram contents wrt recording primary and fallback options. So doing this in a wrapper script cannot actually provide the bootloader resiliency that we are looking for here.

review: Needs Fixing

« Back to merge proposal