Merge ~juliank/grub/+git/ubuntu:ubuntu into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu

Proposed by Julian Andres Klode
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 913744107e433c266b8b6c832f6172420321f4dd
Merged at revision: 913744107e433c266b8b6c832f6172420321f4dd
Proposed branch: ~juliank/grub/+git/ubuntu:ubuntu
Merge into: ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu
Diff against target: 105 lines (+53/-3)
5 files modified
debian/.git-dpm (+2/-2)
debian/changelog (+8/-0)
debian/patches/series (+1/-0)
debian/patches/shorter_version_info.patch (+39/-0)
grub-core/normal/main.c (+3/-1)
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+337338@code.launchpad.net

Description of the change

Show the upstream version only in the screen, and hide the rest in a package_version variable for bug 1723434.

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks good. Feel free to merge this and upload.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/.git-dpm b/debian/.git-dpm
index f89b787..8a85ef0 100644
--- a/debian/.git-dpm
+++ b/debian/.git-dpm
@@ -1,6 +1,6 @@
1# see git-dpm(1) from git-dpm package1# see git-dpm(1) from git-dpm package
218e6620996821d33d36fc71cff2d5862ed24dfd822682d074012bffc6242d607745fafe0bc4d209dc
318e6620996821d33d36fc71cff2d5862ed24dfd832682d074012bffc6242d607745fafe0bc4d209dc
40992ffbac6a1b4c97c350d12e5301e0067daa0d640992ffbac6a1b4c97c350d12e5301e0067daa0d6
50992ffbac6a1b4c97c350d12e5301e0067daa0d650992ffbac6a1b4c97c350d12e5301e0067daa0d6
6grub2_2.02.orig.tar.xz6grub2_2.02.orig.tar.xz
diff --git a/debian/changelog b/debian/changelog
index b0c12de..97e2c79 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
1grub2 (2.02-2ubuntu7) UNRELEASED; urgency=medium
2
3 * debian/patches/shorter_version_info.patch: Only show the upstream version
4 in menu and console, and hide the package one in a package_version
5 variable. (LP: #1723434)
6
7 -- Julian Andres Klode <juliank@ubuntu.com> Thu, 08 Feb 2018 10:50:56 +0100
8
1grub2 (2.02-2ubuntu6) bionic; urgency=medium9grub2 (2.02-2ubuntu6) bionic; urgency=medium
210
3 [ Steve Langasek ]11 [ Steve Langasek ]
diff --git a/debian/patches/series b/debian/patches/series
index 8142c1a..881bbcf 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -73,3 +73,4 @@ dont-fail-efi-warnings.patch
73tsc_efi_default_to_pmtimer.patch73tsc_efi_default_to_pmtimer.patch
74mkconfig_keep_native_term_active.patch74mkconfig_keep_native_term_active.patch
75bufio_sensible_block_sizes.patch75bufio_sensible_block_sizes.patch
76shorter_version_info.patch
diff --git a/debian/patches/shorter_version_info.patch b/debian/patches/shorter_version_info.patch
76new file mode 10064477new file mode 100644
index 0000000..c040d20
--- /dev/null
+++ b/debian/patches/shorter_version_info.patch
@@ -0,0 +1,39 @@
1From 2682d074012bffc6242d607745fafe0bc4d209dc Mon Sep 17 00:00:00 2001
2From: Julian Andres Klode <julian.klode@canonical.com>
3Date: Thu, 8 Feb 2018 10:48:37 +0100
4Subject: Show only upstream version, hide rest in package_version variable
5
6The complete package version can get a bit long, so only show the
7upstream version in the menu and on the top of the console, and
8hide the complete version in a package_version variable.
9
10Bug-Ubuntu: https://bugs.launchpad.net/bugs/1723434
11Last-Updated: 2018-02-08
12
13Patch-Name: shorter_version_info.patch
14---
15 grub-core/normal/main.c | 4 +++-
16 1 file changed, 3 insertions(+), 1 deletion(-)
17
18diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
19index e924f6448..4a6b3bff0 100644
20--- a/grub-core/normal/main.c
21+++ b/grub-core/normal/main.c
22@@ -208,7 +208,7 @@ grub_normal_init_page (struct grub_term_output *term,
23
24 grub_term_cls (term);
25
26- msg_formatted = grub_xasprintf (_("GNU GRUB version %s"), PACKAGE_VERSION);
27+ msg_formatted = grub_xasprintf (_("GNU GRUB version %s"), VERSION);
28 if (!msg_formatted)
29 return;
30
31@@ -560,6 +560,8 @@ GRUB_MOD_INIT(normal)
32 grub_env_export ("grub_cpu");
33 grub_env_set ("grub_platform", GRUB_PLATFORM);
34 grub_env_export ("grub_platform");
35+
36+ grub_env_set ("package_version", PACKAGE_VERSION);
37
38 grub_boot_time ("Normal module prepared");
39 }
diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
index e924f64..4a6b3bf 100644
--- a/grub-core/normal/main.c
+++ b/grub-core/normal/main.c
@@ -208,7 +208,7 @@ grub_normal_init_page (struct grub_term_output *term,
208 208
209 grub_term_cls (term);209 grub_term_cls (term);
210210
211 msg_formatted = grub_xasprintf (_("GNU GRUB version %s"), PACKAGE_VERSION);211 msg_formatted = grub_xasprintf (_("GNU GRUB version %s"), VERSION);
212 if (!msg_formatted)212 if (!msg_formatted)
213 return;213 return;
214 214
@@ -560,6 +560,8 @@ GRUB_MOD_INIT(normal)
560 grub_env_export ("grub_cpu");560 grub_env_export ("grub_cpu");
561 grub_env_set ("grub_platform", GRUB_PLATFORM);561 grub_env_set ("grub_platform", GRUB_PLATFORM);
562 grub_env_export ("grub_platform");562 grub_env_export ("grub_platform");
563
564 grub_env_set ("package_version", PACKAGE_VERSION);
563565
564 grub_boot_time ("Normal module prepared");566 grub_boot_time ("Normal module prepared");
565}567}

Subscribers

People subscribed via source and target branches