Merge lp:~julian-edwards/maas/packaging into lp:~maas-maintainers/maas/packaging

Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 239
Proposed branch: lp:~julian-edwards/maas/packaging
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 121 lines (+28/-9)
8 files modified
debian/changelog (+14/-2)
debian/control (+2/-0)
debian/extras/maas (+4/-0)
debian/maas-cli.install (+1/-1)
debian/maas-cli.links (+1/-0)
debian/maas-dns.postinst (+2/-2)
debian/maas-region-controller-min.install (+1/-1)
debian/maas-region-controller.postinst (+3/-3)
To merge this branch: bzr merge lp:~julian-edwards/maas/packaging
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Jeroen T. Vermeulen (community) Approve
Review via email: mp+205901@code.launchpad.net

Commit message

Rename maas to maas-region-admin, and maas-cli to maas.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

A daring thrust. It looks good to me, although I'm sure I'll be forgetting something. Ultimately only experience will tell.

review: Approve
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hey Julian,

There will be an upgrade issue given that previous maas-region-controller-min installs 'maas' and now 'maas-cli' installs the MAAS binary. A Conflict/Replaces in maas-cli is needed against the latest version maas-region-controller-min that's shipping 'maas'.

review: Needs Fixing
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! Let's just get this tested!

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

I had to fix the maas-cli match with some crazy expr code (unless you want to move the script to use bash, where it's much easier!)

lp:~julian-edwards/maas/packaging updated
239. By Julian Edwards

[r=andreserl,jtv][bug=1052805][author=julian-edwards] Rename maas to maas-region-admin, and maas-cli to maas.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-02-11 15:46:25 +0000
+++ debian/changelog 2014-02-13 05:31:25 +0000
@@ -1,4 +1,4 @@
1maas (1.5+bzr1909-0ubuntu2) UNRELEASED; urgency=low1maas (1.5+bzr1930-0ubuntu1) UNRELEASED; urgency=low
22
3 [ Graham Binns ]3 [ Graham Binns ]
4 * debian/control: Depends on python-jsonschema.4 * debian/control: Depends on python-jsonschema.
@@ -7,7 +7,19 @@
7 * debian/maas-region-controller-min.posinst: Make txlongpoll.yaml only7 * debian/maas-region-controller-min.posinst: Make txlongpoll.yaml only
8 readable by the app and not world readeable.8 readable by the app and not world readeable.
99
10 -- Andres Rodriguez <andreserl@ubuntu.com> Fri, 07 Feb 2014 18:24:08 -050010 [ Julian Edwards ]
11 * debian/extras/maas-cli renamed to debian/extras/maas, and introduce
12 a deprecation warning in favour of using maas over maas-cli.
13 * debian/extras/maas renamed to debian/extras/maas-region-admin
14 * debian/maas-cli.install: install debian/extras/maas
15 * debian/maas-dns.postinst: Invoke maas-region-admin instead of maas
16 * debian/maas-region-controller-min.install: install maas-region-admin
17 instead of maas
18 * debian/maas-region-controller.postinst: Invoke maas-region-admin instead
19 of maas
20 * debian/maas-cli.links: Link from maas to maas-cli for backward compat.
21
22 -- Julian Edwards <julian.edwards@canonical.com> Wed, 12 Feb 2014 15:42:00 +1000
1123
12maas (1.5+bzr1909-0ubuntu1) trusty; urgency=low24maas (1.5+bzr1909-0ubuntu1) trusty; urgency=low
1325
1426
=== modified file 'debian/control'
--- debian/control 2014-02-11 05:10:18 +0000
+++ debian/control 2014-02-13 05:31:25 +0000
@@ -153,6 +153,8 @@
153 python-oauth,153 python-oauth,
154 ${misc:Depends},154 ${misc:Depends},
155 ${python:Depends}155 ${python:Depends}
156Conflicts: maas-region-controller-min (<= 1.5+bzr1909-0ubuntu1)
157Replaces: maas-region-controller-min (<= 1.5+bzr1909-0ubuntu1)
156Description: Ubuntu MAAS Client Tool158Description: Ubuntu MAAS Client Tool
157 Ubuntu MAAS Server is the successor to Orchestra. It offers a159 Ubuntu MAAS Server is the successor to Orchestra. It offers a
158 nice UI to provision your Ubuntu servers. Each physical server160 nice UI to provision your Ubuntu servers. Each physical server
159161
=== renamed file 'debian/extras/maas-cli' => 'debian/extras/maas'
--- debian/extras/maas-cli 2012-09-19 19:00:45 +0000
+++ debian/extras/maas 2014-02-13 05:31:25 +0000
@@ -1,2 +1,6 @@
1#!/bin/sh1#!/bin/sh
2if [ "`expr \"$0\" : \".*maas-cli*\"`" != "0" ];then
3 echo " WARNING: The maas-cli command is deprecated and will be removed" \
4 "in a future\n version. From now on please use 'maas' instead."
5fi
2exec python -m maascli "$@"6exec python -m maascli "$@"
37
=== renamed file 'debian/extras/maas' => 'debian/extras/maas-region-admin'
=== modified file 'debian/maas-cli.install'
--- debian/maas-cli.install 2012-09-20 15:20:51 +0000
+++ debian/maas-cli.install 2014-02-13 05:31:25 +0000
@@ -1,2 +1,2 @@
1debian/extras/maas-cli usr/bin1debian/extras/maas usr/bin
2debian/tmp/usr/lib/python*/dist-packages/maascli2debian/tmp/usr/lib/python*/dist-packages/maascli
33
=== added file 'debian/maas-cli.links'
--- debian/maas-cli.links 1970-01-01 00:00:00 +0000
+++ debian/maas-cli.links 2014-02-13 05:31:25 +0000
@@ -0,0 +1,1 @@
1usr/bin/maas usr/bin/maas-cli
02
=== modified file 'debian/maas-dns.postinst'
--- debian/maas-dns.postinst 2014-01-13 04:06:25 +0000
+++ debian/maas-dns.postinst 2014-02-13 05:31:25 +0000
@@ -5,7 +5,7 @@
5if ([ "$1" = "configure" ] && [ -z "$2" ]) || [ -n "$DEBCONF_RECONFIGURE" ]; then5if ([ "$1" = "configure" ] && [ -z "$2" ]) || [ -n "$DEBCONF_RECONFIGURE" ]; then
6 # If /etc/bind/maas is empty, set_up_dns.6 # If /etc/bind/maas is empty, set_up_dns.
7 if [ ! "$(ls -A /etc/bind/maas)" ]; then7 if [ ! "$(ls -A /etc/bind/maas)" ]; then
8 maas set_up_dns8 maas-region-admin set_up_dns
9 fi9 fi
1010
11 # Fix permissions.11 # Fix permissions.
@@ -26,7 +26,7 @@
26 # Remove any existing MAAS-related include line from26 # Remove any existing MAAS-related include line from
27 # /etc/bind/named.conf.local, then re-add it.27 # /etc/bind/named.conf.local, then re-add it.
28 sed -i '/^include\s.*maas/d' /etc/bind/named.conf.local28 sed -i '/^include\s.*maas/d' /etc/bind/named.conf.local
29 maas get_named_conf --edit --config_path /etc/bind/named.conf.local29 maas-region-admin get_named_conf --edit --config_path /etc/bind/named.conf.local
3030
31 invoke-rc.d bind9 restart || true31 invoke-rc.d bind9 restart || true
32fi32fi
3333
=== modified file 'debian/maas-region-controller-min.install'
--- debian/maas-region-controller-min.install 2013-12-02 22:19:41 +0000
+++ debian/maas-region-controller-min.install 2014-02-13 05:31:25 +0000
@@ -30,7 +30,7 @@
30debian/tmp/etc/maas/templates/commissioning-user-data30debian/tmp/etc/maas/templates/commissioning-user-data
3131
32# Install all other stuff32# Install all other stuff
33debian/extras/maas usr/sbin33debian/extras/maas-region-admin usr/sbin
34debian/extras/maas-region-celeryd usr/sbin34debian/extras/maas-region-celeryd usr/sbin
35debian/extras/20-maas.conf etc/rsyslog.d35debian/extras/20-maas.conf etc/rsyslog.d
36debian/extras/maas_remote_syslog_compress etc/cron.d36debian/extras/maas_remote_syslog_compress etc/cron.d
3737
=== modified file 'debian/maas-region-controller.postinst'
--- debian/maas-region-controller.postinst 2014-01-15 15:38:32 +0000
+++ debian/maas-region-controller.postinst 2014-02-13 05:31:25 +0000
@@ -12,9 +12,9 @@
12RELEASE=`lsb_release -rs` || RELEASE=""12RELEASE=`lsb_release -rs` || RELEASE=""
1313
14maas_sync_migrate_db(){14maas_sync_migrate_db(){
15 maas syncdb --noinput15 maas-region-admin syncdb --noinput
16 maas migrate maasserver --noinput16 maas-region-admin migrate maasserver --noinput
17 maas migrate metadataserver --noinput17 maas-region-admin migrate metadataserver --noinput
18}18}
1919
20restart_rabbitmq(){20restart_rabbitmq(){

Subscribers

People subscribed via source and target branches