Code review comment for lp:~julian-edwards/maas/acl-for-dns-trigger-rewrite

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Monday 01 Sep 2014 03:45:08 you wrote:
> >> It looks to me as if test_writes_dns_when_network_edited should be called
> >> test_writes_dns_when_network_created. Why does it go through the form?
> >
> > 1. It's not just creating, it's any editing (which includes creating).
>
> That's my point. You're not testing that, but the name of the test makes it
> seem as if you do.

I that case I don't see your point. I thought the name was clear enough.

« Back to merge proposal