Merge lp:~julian-edwards/maas/acl-for-dns-trigger-rewrite into lp:~maas-committers/maas/trunk
Proposed by
Julian Edwards
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Julian Edwards | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 2852 | ||||
Proposed branch: | lp:~julian-edwards/maas/acl-for-dns-trigger-rewrite | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
78 lines (+39/-0) 2 files modified
src/maasserver/dns/connect.py (+14/-0) src/maasserver/tests/test_forms_network.py (+25/-0) |
||||
To merge this branch: | bzr merge lp:~julian-edwards/maas/acl-for-dns-trigger-rewrite | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+232834@code.launchpad.net |
Commit message
Connect save and delete signals for Networks so that the DNS config is rewritten. This is so the networks ACL for DNS will get updated when networks change.
To post a comment you must log in.
It looks to me as if test_writes_ dns_when_ network_ edited should be called test_writes_ dns_when_ network_ created. Why does it go through the form?
I still don't like signals for this kind of thing. Do we know what we'll be doing during network auto-discovery? Will we implicitly be firing off a bunch of DNS server restarts concurrently, which may then get confused and break? It would make more sense to me to set some kind of “dirty” flag on DNS, and process that separately.
Also, consider triggering the signal only on specific field changes. Updating the description on a network, or saving it without changes, or perhaps updating some future field that may see routine changes, probably needn't activate the whole DNS machinery.