Code review comment for lp:~jtv/launchpad/fix-more-utilities

Revision history for this message
Robert Collins (lifeless) wrote :

Just a FYI: per pep8 this hunk would be better as
@@ -17,12 +17,13 @@
 class IPackageCloner(Interface):
    """Copies publishing history data across archives."""

     def clonePackages(
- origin, destination, distroarchseries_list=None,
- proc_families=None, sourcepackagenames=None,
- always_create=False, no_duplicates=False):
- """Copies the source packages from origin to destination as
- well as the binary packages for the DistroArchSeries specified.
+ origin, destination, distroarchseries_list=None,
+ proc_families=None, sourcepackagenames=None,
+ always_create=False, no_duplicates):
- """Copies the source packages from origin to destination as
- well as the binary packages for the DistroArchSeries
specified.+ """Copy packages from origin to destination.
+
+ Copies the source packages, as well as the binary packages for the
+ specified `DistroArchSeries`.

That is, the nothing-after-the-( was right, but the indenting was
wrong (which your variant also fixed).

This doesn't particularly bother me but I thought you might like to know ;)

-Rob

« Back to merge proposal