Merge lp:~jtv/launchpad/fix-more-utilities into lp:launchpad
Proposed by
Jeroen T. Vermeulen
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13775 |
Proposed branch: | lp:~jtv/launchpad/fix-more-utilities |
Merge into: | lp:launchpad |
Diff against target: |
87 lines (+13/-13) 4 files modified
lib/lp/bugs/interfaces/bugtask.py (+1/-1) lib/lp/code/interfaces/branchjob.py (+3/-2) lib/lp/soyuz/interfaces/packagecloner.py (+8/-9) lib/lp/soyuz/interfaces/packagediff.py (+1/-1) |
To merge this branch: | bzr merge lp:~jtv/launchpad/fix-more-utilities |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+72666@code.launchpad.net |
Commit message
[r=stevenk][no-qa] Fix some mistakes in utility interfaces.
Description of the change
= Summary =
I've got a sort-of-working prototype of a tool that verifies all our utilities to their utility interfaces.
This branch fixes some of the errors it finds. These are cases where the interface was clearly wrong, and there is no risk of affecting the web service API.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
To post a comment you must log in.
Just a FYI: per pep8 this hunk would be better as Interface) :
@@ -17,12 +17,13 @@
class IPackageCloner(
"""Copies publishing history data across archives."""
def clonePackages( s_list= None, mes=None, create= False, no_duplicates= False): s_list= None, mes=None, create= False, no_duplicates):
- origin, destination, distroarchserie
- proc_families=None, sourcepackagena
- always_
- """Copies the source packages from origin to destination as
- well as the binary packages for the DistroArchSeries specified.
+ origin, destination, distroarchserie
+ proc_families=None, sourcepackagena
+ always_
- """Copies the source packages from origin to destination as
- well as the binary packages for the DistroArchSeries
specified.+ """Copy packages from origin to destination.
+
+ Copies the source packages, as well as the binary packages for the
+ specified `DistroArchSeries`.
That is, the nothing-after-the-( was right, but the indenting was
wrong (which your variant also fixed).
This doesn't particularly bother me but I thought you might like to know ;)
-Rob