Code review comment for lp:~jtv/launchpad/bug-574159

Revision history for this message
Gary Poster (gary) wrote :

Danilo is right. You can test the branch without committing it on ``ec2 test`` with the following option:

  -c, --include-download-cache-changes
                        Include any changes in the download cache (added or
                        unknown) in the download cache of the test run. Note
                        that, if you have any changes in your download cache,
                        trying to submit to pqm will always raise an error.
                        Also note that, if you have any changes in your
                        download cache, you must explicitly choose to include
                        or ignore the changes.

That is nice when you are testing a potentially risky package change--you won't be adding something to the download-cache necessarily (FWIW, I do have a task to remove the bzr-based download-cache eventually).

This package change might not be risky enough to make that necessary and, yes, sooner or later, you'll need to add the tarball to the download-cache.

Thank you!

Gary

review: Approve

« Back to merge proposal