Merge lp:~jtv/launchpad/bug-574159 into lp:launchpad

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Gary Poster
Approved revision: no longer in the source branch.
Merged at revision: 10857
Proposed branch: lp:~jtv/launchpad/bug-574159
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
versions.cfg (+1/-1)
To merge this branch: bzr merge lp:~jtv/launchpad/bug-574159
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email: mp+25041@code.launchpad.net

Commit message

Upgrade to lazr.batchnavigator 1.1.1

Description of the change

= Bug 574159 =

We just fixed a bug in lazr.batchnavigator that made it accept negative batch sizes. Negative sizes tend to lead to oopses.

This branch upgrades Launchpad to lazr.batchnavigator 1.1.1 which contains the fix. I've never done this before, so I hope I'm not forgetting anything.

Jeroen

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Make sure you add the 1.1.1 tarball to download-cache first.

Revision history for this message
Gary Poster (gary) wrote :

Danilo is right. You can test the branch without committing it on ``ec2 test`` with the following option:

  -c, --include-download-cache-changes
                        Include any changes in the download cache (added or
                        unknown) in the download cache of the test run. Note
                        that, if you have any changes in your download cache,
                        trying to submit to pqm will always raise an error.
                        Also note that, if you have any changes in your
                        download cache, you must explicitly choose to include
                        or ignore the changes.

That is nice when you are testing a potentially risky package change--you won't be adding something to the download-cache necessarily (FWIW, I do have a task to remove the bzr-based download-cache eventually).

This package change might not be risky enough to make that necessary and, yes, sooner or later, you'll need to add the tarball to the download-cache.

Thank you!

Gary

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'versions.cfg'
2--- versions.cfg 2010-04-27 15:56:20 +0000
3+++ versions.cfg 2010-05-11 06:58:29 +0000
4@@ -23,7 +23,7 @@
5 ipython = 0.9.1
6 launchpadlib = 1.6.0
7 lazr.authentication = 0.1.1
8-lazr.batchnavigator = 1.1
9+lazr.batchnavigator = 1.1.1
10 lazr.config = 1.1.3
11 lazr.delegates = 1.1.0
12 lazr.enum = 1.1.2