Code review comment for lp:~jtv/launchpad/bug-487428

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

= Bug 487428 =

This is a fixup for the YUI3 upgrade. The management links for a template in a template listing should be greyed out unless the mouse is over them, but the upgrade branch broke this.

The reason is pretty silly: a CSS selector was mis-spelled in a piece of JavaScript. It was done consistently, making it hard to spot the mistake.

No tests are affected; it'd be a lot of work for very little gain to test a visual effect like this, and a test for this would probably have been self-fulfilling by making the same typo. Lastly, the failure mode is benign—the management links were simply always being shown.

To see this in action on a dev system, see:

    https://translations.launchpad.dev/evolution/trunk/+templates

The Edit/Upload/Download/Administer links on the right-hand side of the table should be shown as links only when the mouse pointer hovers over them.

No lint.

Jeroen

« Back to merge proposal