Merge lp:~jtv/launchpad/bug-487428 into lp:launchpad/db-devel

[Jeroen T. Vermeulen]

Fix template listings for YUI3.

[Jeroen T. Vermeulen (jtv)]

= Bug 487428 =

This is a fixup for the YUI3 upgrade. The management links for a template in a template listing should be greyed out unless the mouse is over them, but the upgrade branch broke this.

The reason is pretty silly: a CSS selector was mis-spelled in a piece of JavaScript. It was done consistently, making it hard to spot the mistake.

No tests are affected; it'd be a lot of work for very little gain to test a visual effect like this, and a test for this would probably have been self-fulfilling by making the same typo. Lastly, the failure mode is benign—the management links were simply always being shown.

To see this in action on a dev system, see:

    https://translations.launchpad.dev/evolution/trunk/+templates

The Edit/Upload/Download/Administer links on the right-hand side of the table should be shown as links only when the mouse pointer hovers over them.

No lint.

Jeroen

[Graham Binns (gmb)]

review: Approve (js)

[Jeroen T. Vermeulen (jtv)]

Since this fix touches only JavaScript, I'm sure the js review also counts as a code review. Let's see whether "ec2 land" buys that argument.

review: Approve (code)

=== modified file 'lib/lp/translations/templates/object-templates.pt'
--- lib/lp/translations/templates/object-templates.pt	2009-11-11 22:42:33 +0000
+++ lib/lp/translations/templates/object-templates.pt	2009-11-24 06:35:26 +0000
@@ -37,15 +37,16 @@
       <script language="JavaScript" type="text/javascript">
       YUI().use('node-base', 'event-delegate', function(Y) {
           Y.on('domready', function(e) {
-              Y.all('#template_table .template_links').addClass('inactive_links');
+              Y.all('#templates_table .template_links').addClass(
+                  'inactive_links');
 
               Y.delegate('mouseover', function(e) {
                   this.removeClass('inactive_links');
-              }, '#template_table tbody', '.template_links');
+              }, '#templates_table tbody', '.template_links');
 
               Y.delegate('mouseout', function(e) {
                   this.addClass('inactive_links');
-              }, '#template_table tbody', '.template_links');
+              }, '#templates_table tbody', '.template_links');
           });
       });
       </script>