review-tools

Merge ~jslarraz/review-tools:remove-chromium-overrides into review-tools:master

  1. Git
  2. lp:~jslarraz/review-tools
  3. remove-chromium-overrides
  4. Merge into master
Proposed by Jorge Sancho Larraz
Status: Merged
Merged at revision: 2fef4422e806f32d573b5a85f4d74abcaf33ea00
Proposed branch: ~jslarraz/review-tools:remove-chromium-overrides
Merge into: review-tools:master
Diff against target: 12 lines (+0/-1)
1 file modified
reviewtools/overrides.py (+0/-1)
Reviewer Review Type Date Requested Status
Emilia Torino Approve
Review via email: mp+452115@code.launchpad.net

Commit message

Remove chromium from sec_iface_ref_overrides

Description of the change

Remove chromium from sec_iface_ref_overrides according to https://code.launchpad.net/~dclane/review-tools/+git/review-tools/+merge/451666

To post a comment you must log in.
Revision history for this message
Emilia Torino (emitorino) wrote :

LGTM, thanks!!

This has been added to the chromium declaration on the store side instead

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
2index 72694c7..bbfe49a 100644
3--- a/reviewtools/overrides.py
4+++ b/reviewtools/overrides.py
5@@ -896,7 +896,6 @@ sec_iface_ref_overrides = {
6 "aws-sam-cli": ["config-aws"],
7 "autotrash-unofficial": ["dot-local-share-trash"],
8 "charmcraft": ["dot-hgrc", "gitconfig"],
9- "chromium": ["chromium-config"],
10 "cloudscale-cli": ["dot-cloudscale-ini"],
11 "cw-sh": ["dot-aws-config-credentials"],
12 "doctl": ["doctl-config", "dot-docker", "kube-config"],

Subscribers

People subscribed via source and target branches