Merge ~dclane/review-tools:overrides-chrome into review-tools:master

[David Lane]

reviewtools/overrides.py updates to the interface reference overrides check to allow dot-local-share-applications and dot-local-share-icons.

This change is to allow the chromium snap to pass reviewtools. It was failing because personal files interfaces needed (according to the existing override) to be named 'chromium-config'. This commit adds 2 new personal files interface names to the list of allowable names for chromium.

[Alex Murray (alexmurray)]

sec_iface_ref_overrides is deprecated and existed before we had support for `plug-names` in the snap declaration - so the chromium store declaration should be updated to use `plug-names` instead and we should then remove this entry from overrides.py.

review: Disapprove

[David Lane (dclane)]

I've updated this branch to delete the interface reference override for Chromium, given that that each of the interfaces in it's yaml and in the store declarations all use references appropriately now.

[Alex Murray (alexmurray)]

LGTM! Thanks.

[Alex Murray (alexmurray)]

review: Approve

diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
index 72694c7..bbfe49a 100644
--- a/reviewtools/overrides.py
+++ b/reviewtools/overrides.py
@@ -896,7 +896,6 @@ sec_iface_ref_overrides = {
         "aws-sam-cli": ["config-aws"],
         "autotrash-unofficial": ["dot-local-share-trash"],
         "charmcraft": ["dot-hgrc", "gitconfig"],
-        "chromium": ["chromium-config"],
         "cloudscale-cli": ["dot-cloudscale-ini"],
         "cw-sh": ["dot-aws-config-credentials"],
         "doctl": ["doctl-config", "dot-docker", "kube-config"],