Code review comment for lp:~jshholland/ubuntu/lucid/poppler/backport-anti-alias

Revision history for this message
James Westby (james-w) wrote :

From the bug report:

"Josh: Your patch modifies Makefile.am without updating Makefile.in or causing the packaging to run automake. So it fails to build the new object and dies with a linker error.

After fixing that, it seems to work for me on the examples from this bug, such as ubuntu-manual-draft.pdf.

I would suggest annotating the patch to say where it came from:
https://wiki.ubuntu.com/UbuntuDevelopment/PatchTaggingGuidelines"

Thanks,

James

review: Needs Fixing

« Back to merge proposal