Code review comment for lp:~jseutter/landscape-client/better-config-handling

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Nice work, +1!

Regarding Chad's [1], I don't think we need to expose log_level and data_path in debconf, as changing the former is mainly meant for debugging and the latter for development. So I don't really see use cases for preseeding them, if one wants to change those values it's sufficient to edit them manually in client.conf and they will be picked up and preserved.

And regarding [2], the registration password is optional on both hosted and LDS, so the empty string is a legal value.

As for the crashing bogus values maybe we can address it in a separate branch, it doesn't seem critical as we don't prompt the user for those values, neither with debconf or the interactive landscape-config tool. Actually I'm wondering if we should include them in debconf at all.

review: Approve

« Back to merge proposal