Merge lp:~jseutter/landscape-client/better-config-handling into lp:~landscape/landscape-client/trunk
Proposed by
Jerry Seutter
Status: | Merged |
---|---|
Approved by: | Free Ekanayaka |
Approved revision: | 457 |
Merge reported by: | Jerry Seutter |
Merged at revision: | not available |
Proposed branch: | lp:~jseutter/landscape-client/better-config-handling |
Merge into: | lp:~landscape/landscape-client/trunk |
Diff against target: |
122 lines (+50/-61) 1 file modified
debian/landscape-client.postinst (+50/-61) |
To merge this branch: | bzr merge lp:~jseutter/landscape-client/better-config-handling |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Free Ekanayaka (community) | Approve | ||
Chad Smith | Approve | ||
Review via email: mp+94430@code.launchpad.net |
Description of the change
This branch modifies two things:
- client.conf is no longer backed up before modification. This is back to the old behavior after it was recently changed.
- client.conf is only written to by landscape-config. landscape-
To post a comment you must log in.
+1 This branch behaves as you mentioned in the merge description.
tried feeding bogus values into ping_interval to validate that dpkg-reconfigure crashes and doesn't write the config file if some bogus option values live in /etc/landscape/ client. conf and get passed to landscape-config cmdline.
Couple questions: landscape- client. templates and pull a db_get $PACKAGE/data_path * log_level to pass on the cmdline to landscape-config?
[1] Since we just now got rid of the static landscape-config header values for log_level & data_path, should these default values be added into debian/
68 -log_level = info landscape/ client
69 -data_path = /var/lib/
[2] Why not validate if REGISTRATION_ PASSWORD is non-null too before attempting a registration? I know we've got he --ok-no-register flag set but do we already allow empty registration passwords for clients?
118 + if [ -n "$ACCOUNT_NAME" -a -n "$COMPUTER_TITLE" ]; then