Merge lp:~jr/ubiquity/encryptcheckbox_fix into lp:ubiquity

Proposed by Jonathan Riddell
Status: Merged
Merged at revision: 5790
Proposed branch: lp:~jr/ubiquity/encryptcheckbox_fix
Merge into: lp:ubiquity
Diff against target: 139 lines (+60/-35) (has conflicts)
3 files modified
debian/changelog (+8/-0)
gui/qt/stepUserSetup.ui (+48/-35)
ubiquity/plugins/ubi-usersetup.py (+4/-0)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~jr/ubiquity/encryptcheckbox_fix
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+139485@code.launchpad.net

Description of the change

  * Change encrypt home question to checkbox and indent it under the login
    option to make it clear it is a sub question to the login option

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-12-10 16:35:33 +0000
+++ debian/changelog 2012-12-12 15:21:23 +0000
@@ -4,12 +4,20 @@
4 * Honour base-installer/kernel/altmeta when deciding which kernels to4 * Honour base-installer/kernel/altmeta when deciding which kernels to
5 install or keep installed.5 install or keep installed.
66
7<<<<<<< TREE
7 [ Dmitrijs Ledkovs ]8 [ Dmitrijs Ledkovs ]
8 * Moving question dialog to use a glade ui file, made it non9 * Moving question dialog to use a glade ui file, made it non
9 "re-entrant" safe, i.e. it started to remember previous action area10 "re-entrant" safe, i.e. it started to remember previous action area
10 buttons. The fix is to clear action area, all other parts of the11 buttons. The fix is to clear action area, all other parts of the
11 dialog are always reset with something fresh. (LP: #1087823)12 dialog are always reset with something fresh. (LP: #1087823)
1213
14=======
15 [ Scott Kitterman ]
16 * Change encrypt home question to checkbox and indent it under the login
17 option to make it clear it is a sub question to the login option
18 (LP: #1066225)
19
20>>>>>>> MERGE-SOURCE
13 -- Colin Watson <cjwatson@ubuntu.com> Thu, 06 Dec 2012 17:19:09 +000021 -- Colin Watson <cjwatson@ubuntu.com> Thu, 06 Dec 2012 17:19:09 +0000
1422
15ubiquity (2.13.7) raring; urgency=low23ubiquity (2.13.7) raring; urgency=low
1624
=== modified file 'gui/qt/stepUserSetup.ui'
--- gui/qt/stepUserSetup.ui 2012-02-16 11:22:22 +0000
+++ gui/qt/stepUserSetup.ui 2012-12-12 15:21:23 +0000
@@ -509,41 +509,54 @@
509 </item>509 </item>
510 <item>510 <item>
511 <widget class="QWidget" name="widget_6" native="true">511 <widget class="QWidget" name="widget_6" native="true">
512 <layout class="QGridLayout" name="gridLayout_8">512 <widget class="QCheckBox" name="login_encrypt">
513 <property name="margin">513 <property name="geometry">
514 <number>2</number>514 <rect>
515 </property>515 <x>27</x>
516 <item row="1" column="0" colspan="2">516 <y>27</y>
517 <widget class="QRadioButton" name="login_encrypt">517 <width>291</width>
518 <property name="text">518 <height>21</height>
519 <string>Require Password and decrypt home to login</string>519 </rect>
520 </property>520 </property>
521 <property name="checked">521 <property name="text">
522 <bool>false</bool>522 <string>Require Password and decrypt home to login</string>
523 </property>523 </property>
524 </widget>524 <property name="checked">
525 </item>525 <bool>false</bool>
526 <item row="0" column="1">526 </property>
527 <widget class="QRadioButton" name="login_auto">527 </widget>
528 <property name="text">528 <widget class="QRadioButton" name="login_auto">
529 <string>Log in Automatically</string>529 <property name="geometry">
530 </property>530 <rect>
531 <property name="checked">531 <x>346</x>
532 <bool>false</bool>532 <y>2</y>
533 </property>533 <width>139</width>
534 </widget>534 <height>21</height>
535 </item>535 </rect>
536 <item row="0" column="0">536 </property>
537 <widget class="QRadioButton" name="login_pass">537 <property name="text">
538 <property name="text">538 <string>Log in Automatically</string>
539 <string>Require my password to log in</string>539 </property>
540 </property>540 <property name="checked">
541 <property name="checked">541 <bool>false</bool>
542 <bool>true</bool>542 </property>
543 </property>543 </widget>
544 </widget>544 <widget class="QRadioButton" name="login_pass">
545 </item>545 <property name="geometry">
546 </layout>546 <rect>
547 <x>2</x>
548 <y>2</y>
549 <width>193</width>
550 <height>21</height>
551 </rect>
552 </property>
553 <property name="text">
554 <string>Require my password to log in</string>
555 </property>
556 <property name="checked">
557 <bool>true</bool>
558 </property>
559 </widget>
547 </widget>560 </widget>
548 </item>561 </item>
549 <item>562 <item>
550563
=== modified file 'ubiquity/plugins/ubi-usersetup.py'
--- ubiquity/plugins/ubi-usersetup.py 2012-11-27 06:02:43 +0000
+++ ubiquity/plugins/ubi-usersetup.py 2012-12-12 15:21:23 +0000
@@ -504,6 +504,7 @@
504 #self.page.password.textChanged[str].connect(self.on_password_changed)504 #self.page.password.textChanged[str].connect(self.on_password_changed)
505 #self.page.verified_password.textChanged[str].connect(505 #self.page.verified_password.textChanged[str].connect(
506 # self.on_verified_password_changed)506 # self.on_verified_password_changed)
507 self.page.login_pass.clicked[bool].connect(self.on_login_pass_clicked)
507508
508 self.page.password_debug_warning_label.setVisible(509 self.page.password_debug_warning_label.setVisible(
509 'UBIQUITY_DEBUG' in os.environ)510 'UBIQUITY_DEBUG' in os.environ)
@@ -562,6 +563,9 @@
562 def get_auto_login(self):563 def get_auto_login(self):
563 return self.page.login_auto.isChecked()564 return self.page.login_auto.isChecked()
564565
566 def on_login_pass_clicked(self, checked):
567 self.page.login_encrypt.setEnabled(checked)
568
565 def set_encrypt_home(self, value):569 def set_encrypt_home(self, value):
566 self.page.login_encrypt.setChecked(value)570 self.page.login_encrypt.setChecked(value)
567571

Subscribers

People subscribed via source and target branches

to status/vote changes: