Merge lp:~jr/bzr-builddeb/builddeb-do-rename into lp:bzr-builddeb

Proposed by Jonathan Riddell
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: 620
Merged at revision: 622
Proposed branch: lp:~jr/bzr-builddeb/builddeb-do-rename
Merge into: lp:bzr-builddeb
Diff against target: 85 lines (+9/-8)
3 files modified
__init__.py (+1/-1)
cmds.py (+4/-3)
doc/user_manual/merge.rst (+4/-4)
To merge this branch: bzr merge lp:~jr/bzr-builddeb/builddeb-do-rename
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+77903@code.launchpad.net

Description of the change

Acronym should not be used by default. Rename bd-do to builddeb-do and set bd-do alias.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/3/2011 1:07 PM, Jonathan Riddell wrote:
> Jonathan Riddell has proposed merging
> lp:~jr/bzr-builddeb/builddeb-do-rename into lp:bzr-builddeb.
>
> Requested reviews: Bzr-builddeb-hackers (bzr-builddeb-hackers)
>
> For more details, see:
> https://code.launchpad.net/~jr/bzr-builddeb/builddeb-do-rename/+merge/77903
>
> Acronym should not be used by default. Rename bd-do to
> builddeb-do and set bd-do alias.
>

Looks good to me. Though I think I cannot actually vote on builddeb
proposals.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6Jmn0ACgkQJdeBCYSNAANECgCfXmoQY3JHlHEMSPPaCQrT3+3/
+7cAn1Jpf5bbF1dT+jyOQ6RldWk+x8nU
=Z7vY
-----END PGP SIGNATURE-----

Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '__init__.py'
--- __init__.py 2011-10-01 00:18:46 +0000
+++ __init__.py 2011-10-03 11:08:26 +0000
@@ -35,7 +35,7 @@
3535
3636
37commands = {37commands = {
38 "bd_do": [],38 "builddeb_do": ["bd_do"],
39 "builddeb": ["bd"],39 "builddeb": ["bd"],
40 "dep3_patch": [],40 "dep3_patch": [],
41 "dh_make": ["dh_make"],41 "dh_make": ["dh_make"],
4242
=== modified file 'cmds.py'
--- cmds.py 2011-09-29 10:11:07 +0000
+++ cmds.py 2011-10-03 11:08:26 +0000
@@ -992,7 +992,7 @@
992 location, component, tag_name))992 location, component, tag_name))
993993
994994
995class cmd_bd_do(Command):995class cmd_builddeb_do(Command):
996 """Run a command in an exported package, copying the result back.996 """Run a command in an exported package, copying the result back.
997997
998 For a merge mode package the full source is not available, making some998 For a merge mode package the full source is not available, making some
@@ -1002,7 +1002,7 @@
10021002
1003 For instance:1003 For instance:
10041004
1005 bzr bd-do1005 bzr builddeb-do
10061006
1007 will run a shell in the unpacked source. Any changes you make in the1007 will run a shell in the unpacked source. Any changes you make in the
1008 ``debian/`` directory (and only those made in that directory) will be copied1008 ``debian/`` directory (and only those made in that directory) will be copied
@@ -1011,13 +1011,14 @@
10111011
1012 You can also specify single commands to be run, e.g.1012 You can also specify single commands to be run, e.g.
10131013
1014 bzr bd-do "dpatch-edit-patch 01-fix-build"1014 bzr builddeb-do "dpatch-edit-patch 01-fix-build"
10151015
1016 Note that only the first argument is used as the command, and so the above1016 Note that only the first argument is used as the command, and so the above
1017 example had to be quoted.1017 example had to be quoted.
1018 """1018 """
10191019
1020 takes_args = ['command*']1020 takes_args = ['command*']
1021 aliases = ['bd-do']
10211022
1022 def run(self, command_list=None):1023 def run(self, command_list=None):
1023 t = WorkingTree.open_containing('.')[0]1024 t = WorkingTree.open_containing('.')[0]
10241025
=== modified file 'doc/user_manual/merge.rst'
--- doc/user_manual/merge.rst 2008-08-27 12:54:12 +0000
+++ doc/user_manual/merge.rst 2011-10-03 11:08:26 +0000
@@ -117,7 +117,7 @@
117any files to reflect changes in the upstream build, for instance updating117any files to reflect changes in the upstream build, for instance updating
118``debian/rules``, or ``debian/install``. The last part is updating any118``debian/rules``, or ``debian/install``. The last part is updating any
119patches against the upstream code to work against the latest119patches against the upstream code to work against the latest
120version. To make this easier you can use the ``bd-do`` command. This runs120version. To make this easier you can use the ``builddeb-do`` command. This runs
121the specified command in an exported directory (so you have the full source121the specified command in an exported directory (so you have the full source
122of the package available). If the command is successful then the contents122of the package available). If the command is successful then the contents
123of ``debian/`` is copied back to your branch. If the command fails then123of ``debian/`` is copied back to your branch. If the command fails then
@@ -126,7 +126,7 @@
126126
127For instance you can run::127For instance you can run::
128128
129 bzr bd-do129 bzr builddeb-do
130130
131and have a shell in the unpacked source directory. You can then run any131and have a shell in the unpacked source directory. You can then run any
132commands that you would like. If you then exit the shell normally the contents132commands that you would like. If you then exit the shell normally the contents
@@ -135,10 +135,10 @@
135abort any changes, and they will not show up in your branch.135abort any changes, and they will not show up in your branch.
136136
137You can also run any command by passing it as the first argument to the137You can also run any command by passing it as the first argument to the
138``bd-do`` command. For instance if you use ``dpatch`` in your package the138``builddeb-do`` command. For instance if you use ``dpatch`` in your package the
139following may be useful::139following may be useful::
140140
141 bzr bd-do "dpatch-edit-patch 01-fix-build"141 bzr builddeb-do "dpatch-edit-patch 01-fix-build"
142142
143Note that only the first argument is used, so the command had to be quoted.143Note that only the first argument is used, so the command had to be quoted.
144The command is run through the shell, so you can execute multiple commands144The command is run through the shell, so you can execute multiple commands

Subscribers

People subscribed via source and target branches