Merge lp:~jr/bzr-builddeb/builddeb-do-rename into lp:bzr-builddeb

Proposed by Jonathan Riddell
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: 620
Merged at revision: 622
Proposed branch: lp:~jr/bzr-builddeb/builddeb-do-rename
Merge into: lp:bzr-builddeb
Diff against target: 85 lines (+9/-8)
3 files modified
__init__.py (+1/-1)
cmds.py (+4/-3)
doc/user_manual/merge.rst (+4/-4)
To merge this branch: bzr merge lp:~jr/bzr-builddeb/builddeb-do-rename
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+77903@code.launchpad.net

Description of the change

Acronym should not be used by default. Rename bd-do to builddeb-do and set bd-do alias.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/3/2011 1:07 PM, Jonathan Riddell wrote:
> Jonathan Riddell has proposed merging
> lp:~jr/bzr-builddeb/builddeb-do-rename into lp:bzr-builddeb.
>
> Requested reviews: Bzr-builddeb-hackers (bzr-builddeb-hackers)
>
> For more details, see:
> https://code.launchpad.net/~jr/bzr-builddeb/builddeb-do-rename/+merge/77903
>
> Acronym should not be used by default. Rename bd-do to
> builddeb-do and set bd-do alias.
>

Looks good to me. Though I think I cannot actually vote on builddeb
proposals.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6Jmn0ACgkQJdeBCYSNAANECgCfXmoQY3JHlHEMSPPaCQrT3+3/
+7cAn1Jpf5bbF1dT+jyOQ6RldWk+x8nU
=Z7vY
-----END PGP SIGNATURE-----

Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '__init__.py'
2--- __init__.py 2011-10-01 00:18:46 +0000
3+++ __init__.py 2011-10-03 11:08:26 +0000
4@@ -35,7 +35,7 @@
5
6
7 commands = {
8- "bd_do": [],
9+ "builddeb_do": ["bd_do"],
10 "builddeb": ["bd"],
11 "dep3_patch": [],
12 "dh_make": ["dh_make"],
13
14=== modified file 'cmds.py'
15--- cmds.py 2011-09-29 10:11:07 +0000
16+++ cmds.py 2011-10-03 11:08:26 +0000
17@@ -992,7 +992,7 @@
18 location, component, tag_name))
19
20
21-class cmd_bd_do(Command):
22+class cmd_builddeb_do(Command):
23 """Run a command in an exported package, copying the result back.
24
25 For a merge mode package the full source is not available, making some
26@@ -1002,7 +1002,7 @@
27
28 For instance:
29
30- bzr bd-do
31+ bzr builddeb-do
32
33 will run a shell in the unpacked source. Any changes you make in the
34 ``debian/`` directory (and only those made in that directory) will be copied
35@@ -1011,13 +1011,14 @@
36
37 You can also specify single commands to be run, e.g.
38
39- bzr bd-do "dpatch-edit-patch 01-fix-build"
40+ bzr builddeb-do "dpatch-edit-patch 01-fix-build"
41
42 Note that only the first argument is used as the command, and so the above
43 example had to be quoted.
44 """
45
46 takes_args = ['command*']
47+ aliases = ['bd-do']
48
49 def run(self, command_list=None):
50 t = WorkingTree.open_containing('.')[0]
51
52=== modified file 'doc/user_manual/merge.rst'
53--- doc/user_manual/merge.rst 2008-08-27 12:54:12 +0000
54+++ doc/user_manual/merge.rst 2011-10-03 11:08:26 +0000
55@@ -117,7 +117,7 @@
56 any files to reflect changes in the upstream build, for instance updating
57 ``debian/rules``, or ``debian/install``. The last part is updating any
58 patches against the upstream code to work against the latest
59-version. To make this easier you can use the ``bd-do`` command. This runs
60+version. To make this easier you can use the ``builddeb-do`` command. This runs
61 the specified command in an exported directory (so you have the full source
62 of the package available). If the command is successful then the contents
63 of ``debian/`` is copied back to your branch. If the command fails then
64@@ -126,7 +126,7 @@
65
66 For instance you can run::
67
68- bzr bd-do
69+ bzr builddeb-do
70
71 and have a shell in the unpacked source directory. You can then run any
72 commands that you would like. If you then exit the shell normally the contents
73@@ -135,10 +135,10 @@
74 abort any changes, and they will not show up in your branch.
75
76 You can also run any command by passing it as the first argument to the
77-``bd-do`` command. For instance if you use ``dpatch`` in your package the
78+``builddeb-do`` command. For instance if you use ``dpatch`` in your package the
79 following may be useful::
80
81- bzr bd-do "dpatch-edit-patch 01-fix-build"
82+ bzr builddeb-do "dpatch-edit-patch 01-fix-build"
83
84 Note that only the first argument is used, so the command had to be quoted.
85 The command is run through the shell, so you can execute multiple commands

Subscribers

People subscribed via source and target branches