Code review comment for lp:~jpakkane/libgrip/type_detection_refactoring

Revision history for this message
Chase Douglas (chasedouglas) wrote :

Looks good to me too.

I can't think of any reason not to expose the API publicly, so I'm +1 on that. However, I'll defer judgement to Stephen. To give a second take, in utouch-qml I only expose the type of device in the same sense as grip_get_device_type, so it would mirror what is done there.

All that said, we're up against the feature freeze deadline and this is just a convenience addition. I think we should leave it aside for now if we aren't absolutely sure about it rather than rush it in.

review: Approve

« Back to merge proposal