Merge lp:~jpakkane/libgrip/type_detection_refactoring into lp:libgrip
Proposed by
Jussi Pakkanen
Status: | Merged |
---|---|
Merged at revision: | 55 |
Proposed branch: | lp:~jpakkane/libgrip/type_detection_refactoring |
Merge into: | lp:libgrip |
Diff against target: |
86 lines (+31/-17) 1 file modified
src/gripgesturemanager.c (+31/-17) |
To merge this branch: | bzr merge lp:~jpakkane/libgrip/type_detection_refactoring |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chase Douglas (community) | Approve | ||
Stephen M. Webb (community) | Approve | ||
Review via email: mp+70719@code.launchpad.net |
Description of the change
There are two different locations where input attributes are converted to types. This patch consolidates them into a single function.
It is currently static but we should expose this function in API. Since gesture subscription is done with input types, for symmetry they should be easily and directly available. In fact it is worth asking if the direct/independent attributes should be exposed to libgrip users at all. I don't think that's something they really care about. Should libgrip ever get other backends, they might even not provide those attributes.
Depending on feedback I can add the API exposition here or create a new branch.
To post a comment you must log in.
I have no problem with this patch per se. I would hold off on making the function public until we've had a review of the use stories for the API itself.