Code review comment for lp:~jorge/charms/trusty/mysql/fix-proof

Revision history for this message
Antonio Rosales (arosales) wrote :

Jorge,

Thanks for your contribution to the MySQL charm to ensure this charm is of high quality by having it pass charm proof.

In reviewing your MP I noticed your source default key value was a tab instead of a space. This causes issues with the parsing of the yaml. Thus I made:
  https://code.launchpad.net/~a.rosales/charms/trusty/mysql/add-default-keys/+merge/235064
It simply uses spaces instead of tabs.

Suggest to supersede this MP with https://code.launchpad.net/~a.rosales/charms/trusty/mysql/add-default-keys/+merge/235064

Thanks again for your work on this charm!

-Antonio

review: Needs Fixing

« Back to merge proposal