Merge lp:~jorge/charms/trusty/mysql/fix-proof into lp:charms/trusty/mysql

Proposed by Jorge Castro
Status: Merged
Merge reported by: Charles Butler
Merged at revision: not available
Proposed branch: lp:~jorge/charms/trusty/mysql/fix-proof
Merge into: lp:charms/trusty/mysql
Diff against target: 19 lines (+2/-0)
1 file modified
config.yaml (+2/-0)
To merge this branch: bzr merge lp:~jorge/charms/trusty/mysql/fix-proof
Reviewer Review Type Date Requested Status
Antonio Rosales (community) Needs Fixing
Review Queue (community) cbt Approve
charmers Pending
Review via email:
To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

The results (PASS) are in and available here:

review: Approve (cbt)
Revision history for this message
Antonio Rosales (arosales) wrote :


Thanks for your contribution to the MySQL charm to ensure this charm is of high quality by having it pass charm proof.

In reviewing your MP I noticed your source default key value was a tab instead of a space. This causes issues with the parsing of the yaml. Thus I made:
It simply uses spaces instead of tabs.

Suggest to supersede this MP with

Thanks again for your work on this charm!


review: Needs Fixing
Revision history for this message
Charles Butler (lazypower) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-05-08 11:23:53 +0000
3+++ config.yaml 2014-09-09 23:02:28 +0000
4@@ -80,6 +80,7 @@
5 your ceph cluster).
6 source:
7 type: string
8+ default:
9 description: |
10 Optional configuration to support use of additional sources such as:
11 .
12@@ -91,6 +92,7 @@
13 option.
14 key:
15 type: string
16+ default:
17 description: |
18 Key ID to import to the apt keyring to support use with arbitary source
19 configuration from outside of Launchpad archives or PPA's.


People subscribed via source and target branches

to all changes: