Merge lp:~jorge/charms/trusty/mysql/fix-proof into lp:charms/trusty/mysql

[Jorge Castro]

[Review Queue (review-queue)]

The results (PASS) are in and available here: http://reports.vapour.ws/charm-tests/charm-bundle-test-954-results

review: Approve (cbt)

[Antonio Rosales (arosales)]

Jorge,

Thanks for your contribution to the MySQL charm to ensure this charm is of high quality by having it pass charm proof.

In reviewing your MP I noticed your source default key value was a tab instead of a space. This causes issues with the parsing of the yaml. Thus I made:
  https://code.launchpad.net/~a.rosales/charms/trusty/mysql/add-default-keys/+merge/235064
It simply uses spaces instead of tabs.

Suggest to supersede this MP with https://code.launchpad.net/~a.rosales/charms/trusty/mysql/add-default-keys/+merge/235064

Thanks again for your work on this charm!

-Antonio

review: Needs Fixing

[Charles Butler (lazypower)]

superseded by: https://code.launchpad.net/~a.rosales/charms/trusty/mysql/add-default-keys/+merge/235064

=== modified file 'config.yaml'
--- config.yaml	2014-05-08 11:23:53 +0000
+++ config.yaml	2014-09-09 23:02:28 +0000
@@ -80,6 +80,7 @@
           your ceph cluster).
     source:
         type: string
+        default: 
         description: |
           Optional configuration to support use of additional sources such as:
           .
@@ -91,6 +92,7 @@
           option.
     key:
         type: string
+	default: 
         description: |
           Key ID to import to the apt keyring to support use with arbitary source
           configuration from outside of Launchpad archives or PPA's.