Code review comment for ~johnsca/charm-prometheus2:johnsca/feature/manual-job-relation-2

Revision history for this message
Stuart Bishop (stub) wrote :

Looks good. Please add the glob.escape() bits per inline comment before landing; even if the job name and id are from trusted sources, its easy to escape so others don't need to worry about it.

Still needs a ~prometheus-charmers review.

review: Approve

« Back to merge proposal