~johnsca/charm-prometheus2:johnsca/feature/manual-job-relation-2

Branch merges

Propose for merging

Merged into ~prometheus-charmers/charm-prometheus2:master at revision 24325849d1c27faa6ffcb4a37b85de1a6234ca96

Jeremy Lounder (community): Approve on 2019-08-26

Stuart Bishop (community): Approve on 2019-08-21

Diff: 65 lines (+36/-2)

1 file modified

reactive/prometheus.py (+36/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

a88141c... by Cory Johns on 2019-08-22

Add filename escaping per review

a49b4a8... by Cory Johns on 2019-08-12

Refactor ca_file writing logic out of interface layer into charm

73f9890... by Cory Johns on 2019-08-09

Add relation endpoint for charms to provide manual job configs

The charm currently supports manual job configuration stanzas via charm
config, but that means charms like Kubernetes which want to use those
have to depend on the operator to manually download and pass in the job
config data. This change adds a new relation endpoint for charms to be
able to provide manual job stanzas automatically over the relation.

Also, fix repo URL in layer.yaml

This caused me to waste some time working on the wrong charm when I used
`charm pull-source`. It would be great if we could figure out a better
way to tie a charm to its source layer repo that would be less likely to
get out of date.

Reviewed-on: https://code.launchpad.net/~johnsca/prometheus2-charm/+git/prometheus2-charm/+merge/371005
Reviewed-by: Jeremy Lounder <email address hidden>
Reviewed-by: Stuart Bishop <email address hidden>

af63107... by Cory Johns on 2019-08-06

Add relation endpoint for charms to provide manual job configs

The charm currently supports manual job configuration stanzas via charm
config, but that means charms like Kubernetes which want to use those
have to depend on the operator to manually download and pass in the job
config data. This change adds a new relation endpoint for charms to be
able to provide manual job stanzas automatically over the relation.

2402f41... by Cory Johns on 2019-08-06

Fix repo URL in layer.yaml

This caused me to waste some time working on the wrong charm when I used
`charm pull-source`. It would be great if we could figure out a better
way to tie a charm to its source layer repo that would be less likely to
get out of date.

75278e6... by Tom Haddon on 2019-05-15

Fix typo in metadata.yaml

Reviewed-on: https://code.launchpad.net/~mthaddon/prometheus2-charm/+git/prometheus2-charm/+merge/367463
Reviewed-by: Gareth Woolridge <email address hidden>

5b5a4c2... by Tom Haddon on 2019-05-15

Add full stop in README

93c7fa8... by Roberto Mier Escandon on 2019-05-15

psmisc package is not included in packet.net machines by default and that makes prometheus fail when using killall command:

line 459, in reload_prometheus subprocess.check_call(['killall', '-HUP', 'prometheus'])

Reviewed-on: https://code.launchpad.net/~rmescandon/prometheus2-charm/+git/prometheus2-charm/+merge/358759
Reviewed-by: Tom Haddon <email address hidden>

949d0f5... by Tom Haddon on 2019-05-15

Fix typo in metadata.yaml

89dc19f... by Kevin W Monroe on 2019-05-11

lp:1828063 add a core.snap resource to facilitate offline installs

Reviewed-on: https://code.launchpad.net/~prometheus-charmers/prometheus2-charm/+git/prometheus2-charm/+merge/367206
Reviewed-by: Stuart Bishop <email address hidden>