Code review comment for lp:~johnf-inodes/bzr-email/server_support

Revision history for this message
Robert Collins (lifeless) wrote :

We should perhaps always use a set from address, rather than claiming to the person that wrote it, at least for the body.

I'm not sure why this is needed though: the post_commit_push_pull setting was intended to manage this; I have a concern that autodetecting 'on server side' will interact badly with 'ssh server; commit-something-locally', when that has a checkout from the same machine. Can you tell me more about how this is deployed for you?

review: Needs Information

« Back to merge proposal