Code review comment for lp:~joetalbott/utah/fetch_url

Revision history for this message
Javier Collado (javier.collado) wrote :

@Joe

I see the new VCSHandler classes, but I don't see where they are used. Is this supposed to be followed by more merge requests that replace fetch_cmd with fetch_url and fetch_type?

Aside from this, I think my only comment is that you can replace None checks like this one:
self.assertTrue(bzr is not None)

with something like:
self.assertIsNotNone(bzr)

review: Needs Information

« Back to merge proposal