Merge lp:~joetalbott/utah/fetch_url into lp:utah
Proposed by
Joe Talbott
Status: | Merged |
---|---|
Merged at revision: | 703 |
Proposed branch: | lp:~joetalbott/utah/fetch_url |
Merge into: | lp:utah |
Diff against target: |
212 lines (+195/-0) 3 files modified
utah/client/common.py (+66/-0) utah/client/tests/test_vcs_bzr.py (+53/-0) utah/client/tests/test_vcs_git.py (+76/-0) |
To merge this branch: | bzr merge lp:~joetalbott/utah/fetch_url |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Javier Collado (community) | Approve | ||
Joe Talbott (community) | Needs Resubmitting | ||
Review via email: mp+128322@code.launchpad.net |
Description of the change
This update added several VCS related classes to support bzr and git repositories.
To post a comment you must log in.
@Joe
I see the new VCSHandler classes, but I don't see where they are used. Is this supposed to be followed by more merge requests that replace fetch_cmd with fetch_url and fetch_type?
Aside from this, I think my only comment is that you can replace None checks like this one:
self.assertTrue(bzr is not None)
with something like: tNone(bzr)
self.assertIsNo