Code review comment for lp:~joetalbott/uci-engine/owner_split

Revision history for this message
Ursula Junque (ursinha) wrote :

> Joe,
>
> On the other hand, once we have authentication, the creator can be obtained
> implicitly from self.request.user{.email or a more specific LP user
> reference}.
>
> I would consider a minimum-impact path, by populating "creator" with the
> already provided "owner" in Ticket.save(), so zero changes in the CLI (after
> all we don't want user foo creating tickets as bar). That would carry us
> safely to the point where we have authenticated requests implemented to extend
> tastypie views accordingly.

Just to keep in mind: the reason to have an owner is to annotate the relevant people to be notified about ticket changes, and it's possible that more than one person needs to be notified. We still haven't defined how to notify, if using an IRC bot (then we would need this to be populated with one or more IRC nicks), or else, so assuming the owner is the same as the creator (LP username or email) might need to be changed in a near future.

« Back to merge proposal