Merge lp:~joetalbott/uci-engine/owner_split into lp:uci-engine

[Joe Talbott]

ticket-system - Split owner role into owner and creator.

* -c/--creator is now a required parameter to ubuntu-ci and -o/--owner is optional.
  if no owner is specified the creator value is used for owner as well.

ticket-system - Split owner role into owner and creator.

* -c/--creator is now a required parameter to ubuntu-ci and -o/--owner is optional.
  if no owner is specified the creator value is used for owner as well.

[lp:~joetalbott/uci-engine/owner_split]

742. By Joe Talbott on 2014-08-11

Fix typo

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:741
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1268/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1268/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:742
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1269/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1269/rebuild

review: Needs Fixing (continuous-integration)

[Evan (ev)]

Could you please update the docs to reflect this as well?

[lp:~joetalbott/uci-engine/owner_split]

743. By Joe Talbott on 2014-08-14

ticket-system - Update docs to reflect new owner/creator split.

744. By Joe Talbott on 2014-08-14

cli - Update tests to match new owner/creator split.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:744
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1281/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1281/rebuild

review: Needs Fixing (continuous-integration)

[lp:~joetalbott/uci-engine/owner_split]

745. By Joe Talbott on 2014-08-20

merge with trunk

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:745
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1308/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1308/rebuild

review: Needs Fixing (continuous-integration)

[lp:~joetalbott/uci-engine/owner_split]

746. By Joe Talbott on 2014-08-20

cli - Fix owner/creator logic when updating tickets.

* for new tickets we'll have args.creator
* for existing tickets we'll have args.owner

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:746
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1309/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1309/rebuild

review: Approve (continuous-integration)

[Paul Larson (pwlars)]

Can you also add a line in the docs to say why we even have this? I'm not sure I understand the use case for a different creator and owner. Also, why would we not preserve backwards compatibility with just specifying -o? We could probably change this to say if either one is specified (but not the other) then they are assumed to be the same, right?

review: Needs Information

[Ursula Junque (ursinha)]

I think owner is more important than creator, because the owner is the person/team you want to notify whenever the ticket has changed or requires input (like citrain spreadsheet "Lander"). This way I'd invert the logic and allow the creator to be optional, while the owner (or "lander") is required.

I agree with Paul that the way it's now it's not clear why to split these, is there a use case where you see creator being more important than owner?

review: Needs Information

[lp:~joetalbott/uci-engine/owner_split]

747. By Joe Talbott on 2014-08-21

cli - when creating a ticket accept an owner or creator or both

At least one is required when creating a ticket.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:747
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1312/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1312/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:747
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1313/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1313/rebuild

review: Approve (continuous-integration)

[Joe Talbott (joetalbott)]

Paul and Ursula,

I've updated the MP to allow either of owner or creator to be provided individually or together. If only one is provided it's used for the other. If neither is provided a parser error is raised. I think keeping track of the ticket submitter (creator) is important and am on the fence as to whether only supplying the owner should set the creator.

[Celso Providelo (cprov)]

Joe,

On the other hand, once we have authentication, the creator can be obtained implicitly from self.request.user{.email or a more specific LP user reference}.

I would consider a minimum-impact path, by populating "creator" with the already provided "owner" in Ticket.save(), so zero changes in the CLI (after all we don't want user foo creating tickets as bar). That would carry us safely to the point where we have authenticated requests implemented to extend tastypie views accordingly.

[Ursula Junque (ursinha)]

> Joe,
>
> On the other hand, once we have authentication, the creator can be obtained
> implicitly from self.request.user{.email or a more specific LP user
> reference}.
>
> I would consider a minimum-impact path, by populating "creator" with the
> already provided "owner" in Ticket.save(), so zero changes in the CLI (after
> all we don't want user foo creating tickets as bar). That would carry us
> safely to the point where we have authenticated requests implemented to extend
> tastypie views accordingly.

Just to keep in mind: the reason to have an owner is to annotate the relevant people to be notified about ticket changes, and it's possible that more than one person needs to be notified. We still haven't defined how to notify, if using an IRC bot (then we would need this to be populated with one or more IRC nicks), or else, so assuming the owner is the same as the creator (LP username or email) might need to be changed in a near future.

[Joe Talbott (joetalbott)]

I'm going to reject this MP and submit a new one based on our conversation today.

Unmerged revisions

747. By Joe Talbott on 2014-08-21

cli - when creating a ticket accept an owner or creator or both

At least one is required when creating a ticket.

746. By Joe Talbott on 2014-08-20

cli - Fix owner/creator logic when updating tickets.

* for new tickets we'll have args.creator
* for existing tickets we'll have args.owner

745. By Joe Talbott on 2014-08-20

merge with trunk

744. By Joe Talbott on 2014-08-14

cli - Update tests to match new owner/creator split.

743. By Joe Talbott on 2014-08-14

ticket-system - Update docs to reflect new owner/creator split.

742. By Joe Talbott on 2014-08-11

Fix typo

741. By Joe Talbott on 2014-08-11

ticket-system - Split owner role into owner/creator roles.

=== modified file 'cli/ci_cli/tests/test_cli.py'
--- cli/ci_cli/tests/test_cli.py	2014-08-12 23:55:22 +0000
+++ cli/ci_cli/tests/test_cli.py	2014-08-21 13:48:34 +0000
@@ -54,6 +54,7 @@
             "title": "My cool feature",
             "id": '5',
             "description": "my new feature",
+            "creator": "[e-mail]",
             "owner": "[e-mail]",
             "created": "Wed, 12 Mar 2014 02:18:28 +0000",
             "updated": "Wed, 12 Mar 2014 02:30:22 +0000",
@@ -128,7 +129,7 @@
             'create_ticket',
             '-t', 'New feature',
             '-b', '4321',
-            '-o', '[e-mail]',
+            '-c', '[e-mail]',
             '-d', 'This is a cool new feature',
             '-s', changes_1,
             '-s', changes_2,
@@ -150,7 +151,7 @@
         changes_2 = get_test_file_path(
             'foobar-unsupported_0.1-1ubuntu1_source.changes')
 
-        args = ['create_ticket', '-t', '"New feature"', '-b', '4321', '-o',
+        args = ['create_ticket', '-t', '"New feature"', '-b', '4321', '-c',
                 '[e-mail]', '-d', '"This is a cool new feature"',
                 '-s', changes_1, '-s', changes_2]
 
@@ -274,6 +275,65 @@
             'create_ticket',
             '-t', 'New feature',
             '-d', 'New feature description',
+            '-c', '[e-mail]',
+            '-s', foobar_changes,
+        ]
+        with LogCapture() as lc:
+            logger = logging.getLogger()
+            self.cli.main(args, log=logger)
+        ticket_url = urlparse.urljoin(
+            utils.CI_URL, '/ticket.html?ticket_id=1')
+        # The first output line contains a local absolute host path, so
+        # it is ignored.
+        self.assertEquals(
+            ['Parsing foobar_0.1-1_source.changes...',
+             'Validating .changes...',
+             'foobar_0.1-1 parsed and validated.',
+             'Created source package upload: http://mocked/api/v1/ticket/1/',
+             'Created subticket: http://mocked/api/v1/ticket/1/',
+             'Uploading foobar_0.1-1.dsc ...',
+             'Uploading foobar_0.1.orig.tar.gz ...',
+             'Uploading foobar_0.1-1.debian.tar.gz ...',
+             'Uploading foobar_0.1-1_source.changes ...',
+             'Done! Access {} for more information.'.format(ticket_url),
+             'Created artifact: http://mocked/api/v1/ticket/1/',
+             'Created artifact: http://mocked/api/v1/ticket/1/',
+             'Created artifact: http://mocked/api/v1/ticket/1/',
+             'Created artifact: http://mocked/api/v1/ticket/1/'],
+            list([r.msg for r in lc.records]))
+
+    @mock.patch('ci_cli.utils.post',
+                return_value='http://mocked/api/v1/ticket/1/')
+    @mock.patch('ci_cli.utils.get')
+    @mock.patch('ci_cli.utils.patch')
+    @mock.patch('ci_cli.ticket._open_file')
+    @mock.patch('requests.put')
+    @mock.patch('requests.post')
+    def test_create_ticket_with_owner(self, mocked_post, mocked_put, mocked_of,
+                                      mocked_upa, mocked_ug, mocked_upo):
+        # CLI 'create_ticket' action allows users to upload new sources
+        # via gatekeeper (without swift credentials).
+        mocked_post.side_effect = [
+            FakeResponse(201, '/ticket/1/sandbox/UUID'),
+            FakeResponse(201, '/ticket.html?ticket_id=1'),
+        ]
+        mocked_put.side_effect = [
+            FakeResponse(200, 'A_TEMP_URL'),
+            FakeResponse(201, '/a_sandbox_object_url/'),
+            FakeResponse(200, 'A_TEMP_URL'),
+            FakeResponse(201, '/a_sandbox_object_url/'),
+            FakeResponse(200, 'A_TEMP_URL'),
+            FakeResponse(201, '/a_sandbox_object_url/'),
+            FakeResponse(200, 'A_TEMP_URL'),
+            FakeResponse(201, '/a_sandbox_object_url/'),
+        ]
+        mocked_of.return_value = 'a_content'
+        foobar_changes = get_test_file_path('foobar_0.1-1_source.changes')
+        args = [
+            '-v2',
+            'create_ticket',
+            '-t', 'New feature',
+            '-d', 'New feature description',
             '-o', '[e-mail]',
             '-s', foobar_changes,
         ]
@@ -334,7 +394,7 @@
             'create_ticket',
             '-t', 'New feature',
             '-d', 'New feature description',
-            '-o', '[e-mail]',
+            '-c', '[e-mail]',
             '-s', foobar_changes,
         ]
         mocked_patch.side_effect = [
@@ -397,31 +457,33 @@
         with capture_stderr(self.assertRaises, SystemExit, self.cli.main,
                             args) as cm:
             self.assertNotEqual(cm, None)
-        self.assertTrue(expected_msg in cm)
+        self.assertTrue(expected_msg in cm, "cm: {}, expected_msg: {}".format(
+            cm, expected_msg))
 
     def test_cli_arguments_are_required(self):
         """Verify cli arguments are required."""
         args = ['create_ticket']
         self._test_parser_missing_arguments(
             args, "create_ticket: error: argument -t/--title is required")
-
         args.extend(['-t', '"New feature"'])
+
         self._test_parser_missing_arguments(
             args,
             "create_ticket: error: argument -d/--description is required")
-
         args.extend(['-d', '"This is a cool new feature"'])
-        self._test_parser_missing_arguments(
-            args, "create_ticket: error: argument -o/--owner is required")
-
-        args.extend(['-o', '[e-mail]'])
 
         self._test_parser_missing_arguments(
             args, "create_ticket: error: argument -s/--sources is required")
+        args.extend(['-s', 'foobar.changesss'])
+
+        self._test_parser_missing_arguments(
+            args, "error: at least one of the arguments "
+            "-o/--owner or -c/--creator is required")
+
+        args.extend(['-c', '[e-mail]'])
 
         # All arguments were provided. It should fail because file is not
         # found.
-        args.extend(['-s', 'foobar.changesss'])
         with LogCapture() as lc:
             logger = logging.getLogger()
             self.cli.main(args, log=logger)
@@ -432,7 +494,7 @@
         """Verify cli fails in case file isn't prefixed .changes."""
         wrong_changes = get_test_file_path('foobar_0.1-1.dsc')
         args = ['create_ticket', '-t', '"New feature"', '-d',
-                '"This is a cool new feature"', '-o', '[e-mail]',
+                '"This is a cool new feature"', '-c', '[e-mail]',
                 '-s', wrong_changes]
         with LogCapture() as lc:
             logger = logging.getLogger()
@@ -453,7 +515,7 @@
         """Verify cli behavior when .changes file is a .dsc."""
         wrong_changes = get_test_file_path('foobar_0.1-1_dsc.changes')
         args = ['create_ticket', '-t', '"New feature"', '-d',
-                '"This is a cool new feature"', '-o', '[e-mail]',
+                '"This is a cool new feature"', '-c', '[e-mail]',
                 '-s', wrong_changes]
         with LogCapture() as lc:
             logger = logging.getLogger()
@@ -470,7 +532,7 @@
         """Verify cli behavior when provided .changes file isn't a .changes."""
         wrong_changes = get_test_file_path('foobar_0.1-1_random.changes')
         args = ['create_ticket', '-t', '"New feature"', '-d',
-                '"This is a cool new feature"', '-o', '[e-mail]',
+                '"This is a cool new feature"', '-c', '[e-mail]',
                 '-s', wrong_changes]
         with LogCapture() as lc:
             logger = logging.getLogger()
@@ -488,7 +550,7 @@
         unsigned_changes = get_test_file_path(
             'foobar_0.1-1_unsigned.changes')
         args = ['create_ticket', '-t', '"New feature"', '-d',
-                '"This is a cool new feature"', '-o', '[e-mail]',
+                '"This is a cool new feature"', '-c', '[e-mail]',
                 '-s', unsigned_changes]
         with LogCapture() as lc:
             logger = logging.getLogger()
@@ -507,7 +569,7 @@
         changes_filename = 'foobar_0.1-1_unreleased.changes'
         wrong_changes = get_test_file_path(changes_filename)
         args = ['create_ticket', '-t', '"New feature"', '-d',
-                '"This is a cool new feature"', '-o', '[e-mail]',
+                '"This is a cool new feature"', '-c', '[e-mail]',
                 '-s', wrong_changes]
         with LogCapture() as lc:
             logger = logging.getLogger()
@@ -527,7 +589,7 @@
         changes_filename = 'foobar-unsupported_0.1-1ubuntu1_source.changes'
         wrong_changes = get_test_file_path(changes_filename)
         args = ['create_ticket', '-t', '"New feature"', '-d',
-                '"This is a cool new feature"', '-o', '[e-mail]',
+                '"This is a cool new feature"', '-c', '[e-mail]',
                 '-s', wrong_changes]
         with LogCapture() as lc:
             logger = logging.getLogger()

=== modified file 'cli/ci_cli/tests/test_ticket.py'
--- cli/ci_cli/tests/test_ticket.py	2014-08-13 13:13:21 +0000
+++ cli/ci_cli/tests/test_ticket.py	2014-08-21 13:48:34 +0000
@@ -208,7 +208,8 @@
     @mock.patch('ci_cli.utils.post',
                 return_value='http://www.example.com/api/v1/sourcepackage/4/')
     def test_create_sourcepackage(self, mock_post):
-        new_subticket = SubTicket(owner='[e-mail]', ticket_id=4)
+        new_subticket = SubTicket(creator='[e-mail]',
+                                  owner='[e-mail]', ticket_id=4)
         with mock.patch('sys.stdout'):
             new_subticket._parse_changes(self.changes)
         sourcepackage_uri = new_subticket._create_sourcepackage()
@@ -220,7 +221,8 @@
     @mock.patch('ci_cli.utils.post',
                 return_value='http://www.example.com/api/v1/spu/38/')
     def test_create_spu(self, mock_post, mock_sp_uri):
-        new_subticket = SubTicket(owner='[e-mail]', ticket_id=3)
+        new_subticket = SubTicket(creator='[e-mail]',
+                                  owner='[e-mail]', ticket_id=3)
         with mock.patch('sys.stdout'):
             new_subticket._parse_changes(self.changes)
         new_subticket._create_spu()
@@ -232,7 +234,8 @@
                 return_value='http://www.example.com/api/v1/spu/39/')
     def test_create_spu_sourcepackage_not_found(self, mock_spu_post, mock_post,
                                                 mock_sp_uri):
-        new_subticket = SubTicket(owner='[e-mail]', ticket_id=3)
+        new_subticket = SubTicket(creator='[e-mail]',
+                                  owner='[e-mail]', ticket_id=3)
         with mock.patch('sys.stdout'):
             new_subticket._parse_changes(self.changes)
         new_subticket._create_spu()
@@ -242,7 +245,8 @@
         return_value='http://www.example.com/api/v1/subticketartifact/38/',
     )
     def test_create_artifact(self, mock_post):
-        new_subticket = SubTicket(owner='[e-mail]', ticket_id=2)
+        new_subticket = SubTicket(creator='[e-mail]',
+                                  owner='[e-mail]', ticket_id=2)
         file = 'foobar_source.changes'
         location = 'http://www.example.com/path/to/foobar_source.changes'
         new_subticket._create_artifact(file, location)
@@ -251,7 +255,8 @@
     @mock.patch('ci_cli.utils.post',
                 return_value='http://www.example.com/api/v1/subticket/1/')
     def test_create_subticket(self, mock_post):
-        new_subticket = SubTicket(owner='[e-mail]', ticket_id=1)
+        new_subticket = SubTicket(creator='[e-mail]',
+                                  owner='[e-mail]', ticket_id=1)
         new_subticket._create_subticket()
 
 
@@ -261,7 +266,7 @@
                 return_value='http://www.example.com/api/v1/ticket/38/')
     def test_create_ticket(self, mock_post):
         changes = get_test_file_path('foobar_0.1-1_source.changes')
-        args = ['create_ticket', '-t', 'New feature', '-b', '1234', '-o',
+        args = ['create_ticket', '-t', 'New feature', '-b', '1234', '-c',
                 '[e-mail]', '-d', 'This is a cool new feature',
                 '-s', changes]
 
@@ -280,7 +285,7 @@
             'create_ticket',
             '-t', 'New feature',
             '-b', '1234',
-            '-o', '[e-mail]',
+            '-c', '[e-mail]',
             '-d', 'This is a cool new feature',
             '-s', changes,
         ]
@@ -307,7 +312,7 @@
             'create_ticket',
             '-t', 'New feature',
             '-b', '1234',
-            '-o', '[e-mail]',
+            '-c', '[e-mail]',
             '-d', 'This is a cool new feature',
             '-s', changes,
             '-w'
@@ -342,6 +347,7 @@
             '{}/api/v1/ticket/'.format(utils.CI_URL),
             data={
                 'owner': '[e-mail]',
+                'creator': '[e-mail]',
                 'series': 'trusty',
                 'bug_id': '1234',
                 'description': 'This is a cool new feature',
@@ -367,7 +373,7 @@
             'create_ticket',
             '-t', 'New feature',
             '-b', '4321',
-            '-o', '[e-mail]',
+            '-c', '[e-mail]',
             '-d', 'This is a cool new feature',
             '-s', changes_1,
             '-s', changes_2,

=== modified file 'cli/ci_cli/ticket.py'
--- cli/ci_cli/ticket.py	2014-08-18 19:01:55 +0000
+++ cli/ci_cli/ticket.py	2014-08-21 13:48:34 +0000
@@ -138,8 +138,9 @@
 
 class SubTicket():
 
-    def __init__(self, owner, ticket_id=None):
-        self.owner = owner
+    def __init__(self, creator, ticket_id=None, owner=None):
+        self.creator = creator
+        self.owner = owner if owner is not None else creator
         self.ticket_id = ticket_id
         self.sourcepackage = ''
         self.files = ''
@@ -241,7 +242,8 @@
     def _create_ticket(self, args):
         data = {
             "title": args.title,
-            "owner": args.owner,
+            "owner": args.owner if args.owner else args.creator,
+            "creator": args.creator if args.creator else args.owner,
             "description": args.description,
             "series": self.suite.split("-")[0],
             "bug_id": args.bug,
@@ -280,9 +282,13 @@
         to the same suite.
         """
         suites = set()
+        if hasattr(args, 'creator'):
+            creator = args.creator
+        else:
+            creator = args.owner
         # First, process all sources and validate the series.
         for source in args.sources:
-            subticket = SubTicket(owner=args.owner)
+            subticket = SubTicket(owner=args.owner, creator=creator)
             subticket._parse_changes(source)
             suites.add(subticket.suite)
             self.subtickets[subticket.sourcepackage] = subticket

=== modified file 'cli/ubuntu-ci'
--- cli/ubuntu-ci	2014-08-14 18:57:54 +0000
+++ cli/ubuntu-ci	2014-08-21 13:48:34 +0000
@@ -53,8 +53,10 @@
                                help='Ticket description')
     ticket_parser.add_argument('-b', '--bug',
                                help='Related bug number')
-    ticket_parser.add_argument('-o', '--owner', required=True,
+    ticket_parser.add_argument('-o', '--owner',
                                help='Email address of the ticket owner')
+    ticket_parser.add_argument('-c', '--creator',
+                               help='Email address of the ticket creator')
     ticket_parser.add_argument('-s', '--sources', action='append',
                                help='Path to source.changes files. '
                                'Source package files (e.g. source.dsc, '
@@ -110,7 +112,29 @@
                               help='Desired file name (and path) for the '
                               'downloaded image', required=True)
     image_parser.set_defaults(func=image.get_image)
-    return parser.parse_args(args)
+    args = parser.parse_args(args)
+
+    if not _has_valid_owner_creator(args):
+        parser.error("at least one of the arguments -o/--owner or "
+                     "-c/--creator is required")
+
+    return args
+
+
+def _has_valid_owner_creator(args):
+    if hasattr(args, 'func'):
+        # only certain subcommands need to require an owner/creator
+        if args.func.func_name not in ['new_ticket']:
+            return True
+
+    if not (hasattr(args, 'owner') or hasattr(args, 'creator')):
+        return False
+
+    if (hasattr(args, 'owner') and args.owner is None) and (
+            hasattr(args, 'creator') and args.creator is None):
+        return False
+
+    return True
 
 
 def set_log_level(logger, loglevel):

=== modified file 'docs/api/initial-request.rst'
--- docs/api/initial-request.rst	2014-08-05 18:14:05 +0000
+++ docs/api/initial-request.rst	2014-08-21 13:48:34 +0000
@@ -10,7 +10,7 @@
 
 ::
 
- python ubuntu-ci create_ticket -t "Ticket name" -d "Ticket description" -b 123 -o [e-mail] -s /full/path/to/_source.changes -s /full/path/to/_source.changes
+ python ubuntu-ci create_ticket -t "Ticket name" -d "Ticket description" -b 123 -c [e-mail] -s /full/path/to/_source.changes -s /full/path/to/_source.changes
 
 CLI -> Ticket System
 --------------------

=== modified file 'docs/usage.rst'
--- docs/usage.rst	2014-08-05 18:14:05 +0000
+++ docs/usage.rst	2014-08-21 13:48:34 +0000
@@ -53,7 +53,7 @@
 
 .. code-block:: none
 
-  ubuntu-ci [-S|--url] create_ticket -t "Ticket name" -d "Ticket description" -b 123 -o [e-mail] -s /full/path/to/_source.changes -s /full/path/to/_source.changes
+  ubuntu-ci [-S|--url] create_ticket -t "Ticket name" -d "Ticket description" -b 123 -c [e-mail] -s /full/path/to/_source.changes -s /full/path/to/_source.changes
 
 This returns a ticket ID which can later be used to monitor and check for
 results. Once the ticket is created, the Ubuntu CI Engine does the rest. The
@@ -86,8 +86,10 @@
     -d DESCRIPTION, --description DESCRIPTION
                           Ticket description
     -b BUG, --bug BUG     Related bug number
+    -c CREATOR, --creator CREATOR
+                          Email address of the ticket creator
     -o OWNER, --owner OWNER
-                          Email address of the ticket owner
+                          Email address of the ticket owner (default: CREATOR)
     -s SOURCES, --sources SOURCES
                           Path to source.changes files. Source package files
                           (e.g. source.dsc, source.orig.tar.gz, etc.) are

=== modified file 'ticket_system/ticket/api.py'
--- ticket_system/ticket/api.py	2014-08-07 20:45:58 +0000
+++ ticket_system/ticket/api.py	2014-08-21 13:48:34 +0000
@@ -403,6 +403,7 @@
             return ip
         url = 'http://{}:8080/api/v1/ticket/'.format(ip)
         ticket_content = {"owner": "[e-mail]",
+                          "creator": "[e-mail]",
                           "title": "Created ticket",
                           "description": "This ticket is for creation test",
                           "bug_id": "111111",

=== added file 'ticket_system/ticket/migrations/0008_auto__add_field_ticket_creator__chg_field_ticket_owner.py'
--- ticket_system/ticket/migrations/0008_auto__add_field_ticket_creator__chg_field_ticket_owner.py	1970-01-01 00:00:00 +0000
+++ ticket_system/ticket/migrations/0008_auto__add_field_ticket_creator__chg_field_ticket_owner.py	2014-08-21 13:48:34 +0000
@@ -0,0 +1,111 @@
+# -*- coding: utf-8 -*-
+import datetime
+from south.db import db
+from south.v2 import SchemaMigration
+from django.db import models
+
+
+class Migration(SchemaMigration):
+
+    def forwards(self, orm):
+        # Adding field 'Ticket.creator'
+        db.add_column('ticket', 'creator',
+                      self.gf('django.db.models.fields.EmailField')(default='unknown', max_length=4096),
+                      keep_default=False)
+
+
+        # Changing field 'Ticket.owner'
+        db.alter_column('ticket', 'owner', self.gf('django.db.models.fields.EmailField')(max_length=4096))
+
+    def backwards(self, orm):
+        # Deleting field 'Ticket.creator'
+        db.delete_column('ticket', 'creator')
+
+
+        # Changing field 'Ticket.owner'
+        db.alter_column('ticket', 'owner', self.gf('django.db.models.fields.EmailField')(max_length=254))
+
+    models = {
+        u'project.sourcepackage': {
+            'Meta': {'object_name': 'SourcePackage', 'db_table': "'sourcepackage'"},
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '4096'})
+        },
+        u'ticket.mergeproposal': {
+            'Meta': {'object_name': 'MergeProposal', 'db_table': "'mergeproposal'"},
+            'approved_revno': ('django.db.models.fields.IntegerField', [], {}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'lp_url': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'project': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'sourcepackage': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['project.SourcePackage']"}),
+            'target_branch': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'version': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        },
+        u'ticket.review': {
+            'Meta': {'object_name': 'Review'},
+            'completed': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'review_type': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'ticket': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['ticket.Ticket']"}),
+            'workflow_step': ('django.db.models.fields.IntegerField', [], {})
+        },
+        u'ticket.sourcepackageupload': {
+            'Meta': {'object_name': 'SourcePackageUpload', 'db_table': "'sourcepackageupload'"},
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'sourcepackage': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['project.SourcePackage']"}),
+            'version': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        },
+        u'ticket.subticket': {
+            'Meta': {'object_name': 'SubTicket', 'db_table': "'subticket'"},
+            'assignee': ('django.db.models.fields.EmailField', [], {'max_length': '254'}),
+            'current_workflow_step': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '4096'}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'merge_proposal': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['ticket.MergeProposal']", 'null': 'True', 'blank': 'True'}),
+            'source_package_upload': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['ticket.SourcePackageUpload']", 'null': 'True', 'blank': 'True'}),
+            'status': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '4096'}),
+            'ticket': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['ticket.Ticket']"})
+        },
+        u'ticket.subticketartifact': {
+            'Meta': {'object_name': 'SubTicketArtifact', 'db_table': "'subticket_artifact'"},
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'reference': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'subticket': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['ticket.SubTicket']", 'null': 'True'}),
+            'type': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        },
+        u'ticket.ticket': {
+            'Meta': {'object_name': 'Ticket', 'db_table': "'ticket'"},
+            'base_image': ('django.db.models.fields.CharField', [], {'default': "''", 'max_length': '4096'}),
+            'bug_id': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}),
+            'created': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}),
+            'creator': ('django.db.models.fields.EmailField', [], {'max_length': '4096'}),
+            'current_workflow_step': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '4096'}),
+            'description': ('django.db.models.fields.TextField', [], {}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'lander_unit': ('django.db.models.fields.IntegerField', [], {'default': '0'}),
+            'master_ppa': ('django.db.models.fields.CharField', [], {'default': "''", 'max_length': '4096'}),
+            'owner': ('django.db.models.fields.EmailField', [], {'max_length': '4096'}),
+            'private': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            'series': ('django.db.models.fields.CharField', [], {'default': "''", 'max_length': '4096'}),
+            'status': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '4096'}),
+            'title': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'updated': ('django.db.models.fields.DateTimeField', [], {'auto_now': 'True', 'blank': 'True'}),
+            'uuid': ('django.db.models.fields.CharField', [], {'default': "'1b1a4510-1db3-11e4-9bc5-4437e68484d8'", 'unique': 'True', 'max_length': '36'}),
+            'workflow': ('django.db.models.fields.related.ForeignKey', [], {'default': "'default'", 'to': u"orm['ticket.Workflow']"})
+        },
+        u'ticket.ticketartifact': {
+            'Meta': {'object_name': 'TicketArtifact', 'db_table': "'ticket_artifact'"},
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'reference': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'ticket': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['ticket.Ticket']", 'null': 'True'}),
+            'type': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        },
+        u'ticket.workflow': {
+            'Meta': {'object_name': 'Workflow'},
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '4096', 'primary_key': 'True'}),
+            'steps': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        }
+    }
+
+    complete_apps = ['ticket']
\ No newline at end of file

=== added file 'ticket_system/ticket/migrations/0009_add_creator.py'
--- ticket_system/ticket/migrations/0009_add_creator.py	1970-01-01 00:00:00 +0000
+++ ticket_system/ticket/migrations/0009_add_creator.py	2014-08-21 13:48:34 +0000
@@ -0,0 +1,103 @@
+# -*- coding: utf-8 -*-
+import datetime
+from south.db import db
+from south.v2 import DataMigration
+from django.db import models
+
+class Migration(DataMigration):
+
+    def forwards(self, orm):
+        # Note: Remember to use orm['appname.ModelName'] rather than "from appname.models..."
+
+        for ticket in orm.Ticket.objects.all():
+            ticket.creator = ticket.owner
+            ticket.save()
+
+    def backwards(self, orm):
+        raise RuntimeError("This migration cannot be reversed")
+
+    models = {
+        u'project.sourcepackage': {
+            'Meta': {'object_name': 'SourcePackage', 'db_table': "'sourcepackage'"},
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '4096'})
+        },
+        u'ticket.mergeproposal': {
+            'Meta': {'object_name': 'MergeProposal', 'db_table': "'mergeproposal'"},
+            'approved_revno': ('django.db.models.fields.IntegerField', [], {}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'lp_url': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'project': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'sourcepackage': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['project.SourcePackage']"}),
+            'target_branch': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'version': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        },
+        u'ticket.review': {
+            'Meta': {'object_name': 'Review'},
+            'completed': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'review_type': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'ticket': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['ticket.Ticket']"}),
+            'workflow_step': ('django.db.models.fields.IntegerField', [], {})
+        },
+        u'ticket.sourcepackageupload': {
+            'Meta': {'object_name': 'SourcePackageUpload', 'db_table': "'sourcepackageupload'"},
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'sourcepackage': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['project.SourcePackage']"}),
+            'version': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        },
+        u'ticket.subticket': {
+            'Meta': {'object_name': 'SubTicket', 'db_table': "'subticket'"},
+            'assignee': ('django.db.models.fields.EmailField', [], {'max_length': '254'}),
+            'current_workflow_step': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '4096'}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'merge_proposal': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['ticket.MergeProposal']", 'null': 'True', 'blank': 'True'}),
+            'source_package_upload': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['ticket.SourcePackageUpload']", 'null': 'True', 'blank': 'True'}),
+            'status': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '4096'}),
+            'ticket': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['ticket.Ticket']"})
+        },
+        u'ticket.subticketartifact': {
+            'Meta': {'object_name': 'SubTicketArtifact', 'db_table': "'subticket_artifact'"},
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'reference': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'subticket': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['ticket.SubTicket']", 'null': 'True'}),
+            'type': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        },
+        u'ticket.ticket': {
+            'Meta': {'object_name': 'Ticket', 'db_table': "'ticket'"},
+            'base_image': ('django.db.models.fields.CharField', [], {'default': "''", 'max_length': '4096'}),
+            'bug_id': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}),
+            'created': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}),
+            'creator': ('django.db.models.fields.EmailField', [], {'max_length': '4096'}),
+            'current_workflow_step': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '4096'}),
+            'description': ('django.db.models.fields.TextField', [], {}),
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'lander_unit': ('django.db.models.fields.IntegerField', [], {'default': '0'}),
+            'master_ppa': ('django.db.models.fields.CharField', [], {'default': "''", 'max_length': '4096'}),
+            'owner': ('django.db.models.fields.EmailField', [], {'max_length': '4096'}),
+            'private': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            'series': ('django.db.models.fields.CharField', [], {'default': "''", 'max_length': '4096'}),
+            'status': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '4096'}),
+            'title': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'updated': ('django.db.models.fields.DateTimeField', [], {'auto_now': 'True', 'blank': 'True'}),
+            'uuid': ('django.db.models.fields.CharField', [], {'default': "'458c437a-1db3-11e4-ad48-4437e68484d8'", 'unique': 'True', 'max_length': '36'}),
+            'workflow': ('django.db.models.fields.related.ForeignKey', [], {'default': "'default'", 'to': u"orm['ticket.Workflow']"})
+        },
+        u'ticket.ticketartifact': {
+            'Meta': {'object_name': 'TicketArtifact', 'db_table': "'ticket_artifact'"},
+            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'reference': ('django.db.models.fields.CharField', [], {'max_length': '4096'}),
+            'ticket': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['ticket.Ticket']", 'null': 'True'}),
+            'type': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        },
+        u'ticket.workflow': {
+            'Meta': {'object_name': 'Workflow'},
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '4096', 'primary_key': 'True'}),
+            'steps': ('django.db.models.fields.CharField', [], {'max_length': '4096'})
+        }
+    }
+
+    complete_apps = ['ticket']
+    symmetrical = True

=== modified file 'ticket_system/ticket/models.py'
--- ticket_system/ticket/models.py	2014-08-18 19:23:55 +0000
+++ ticket_system/ticket/models.py	2014-08-21 13:48:34 +0000
@@ -108,7 +108,8 @@
         max_length=36, editable=False, unique=True, default=get_ticket_uuid,
         help_text=('UUIDv1 ticket identification represented as '
                    'string (aka \'hyphenated\').'))
-    owner = models.EmailField(max_length=254)
+    owner = models.EmailField(max_length=4096)
+    creator = models.EmailField(max_length=4096)
     title = models.CharField(max_length=4096)
     description = models.TextField()
     bug_id = models.IntegerField(null=True, blank=True)

=== modified file 'ticket_system/ticket/tests/test_full_read_api.py'
--- ticket_system/ticket/tests/test_full_read_api.py	2014-08-05 00:42:26 +0000
+++ ticket_system/ticket/tests/test_full_read_api.py	2014-08-21 13:48:34 +0000
@@ -93,6 +93,7 @@
             u'created': unicode(self.ticket.created.strftime(
                 settings.TEST_DATETIME_FORMAT)),
             u'owner': unicode(self.ticket.owner),
+            u'creator': unicode(self.ticket.creator),
             u'base_image': unicode(self.ticket.base_image),
             u'id': self.ticket.pk,
             u'lander_unit': 0,

=== modified file 'ticket_system/ticket/tests/test_models.py'
--- ticket_system/ticket/tests/test_models.py	2014-08-05 20:20:26 +0000
+++ ticket_system/ticket/tests/test_models.py	2014-08-21 13:48:34 +0000
@@ -70,12 +70,14 @@
 def create_ticket(title="This is my ticket",
                   description="this is my ticket description",
                   bug_id='12345', owner='[e-mail]',
+                  creator='[e-mail]',
                   current_workflow_step=TicketWorkflowStep.PKG_BUILDING,
                   status=TicketWorkflowStepStatus.INPROGRESS,
                   base_image='17', series='saucy',
                   master_ppa='ci-engine/ppa'):
     ticket = Ticket()
     ticket.owner = owner
+    ticket.creator = creator
     ticket.title = title
     ticket.description = description
     ticket.bug_id = bug_id
@@ -149,7 +151,8 @@
         self.addCleanup(_m.stop)
         # Creating tickets, independently of its status, creates its
         # container.
-        self.ticket = create_ticket(owner='[e-mail]')
+        self.ticket = create_ticket(owner='[e-mail]',
+                                    creator='[e-mail]')
         self.create_container.assert_called_once()
 
     def test_creating_an_artifact_subticket(self):

=== modified file 'ticket_system/ticket/tests/test_read_api.py'
--- ticket_system/ticket/tests/test_read_api.py	2014-08-05 00:42:26 +0000
+++ ticket_system/ticket/tests/test_read_api.py	2014-08-21 13:48:34 +0000
@@ -105,6 +105,7 @@
                     u'title': unicode(self.ticket.title),
                     u'bug_id': self.ticket.bug_id,
                     u'owner': unicode(self.ticket.owner),
+                    u'creator': unicode(self.ticket.creator),
                     u'base_image': unicode(self.ticket.base_image),
                     u'id': self.ticket.pk,
                     u'lander_unit': 0,
@@ -142,6 +143,7 @@
                 u'title': unicode(self.ticket.title),
                 u'bug_id': self.ticket.bug_id,
                 u'owner': unicode(self.ticket.owner),
+                u'creator': unicode(self.ticket.creator),
                 u'base_image': unicode(self.ticket.base_image),
                 u'id': self.ticket.pk,
                 u'lander_unit': 0,
@@ -194,6 +196,7 @@
                 u'lander_unit': 0,
                 u'master_ppa': unicode(self.ticket.master_ppa),
                 u'owner': unicode(self.ticket.owner),
+                u'creator': unicode(self.ticket.creator),
                 u'status': unicode(get_enum_title(self.ticket.status,
                                    TicketWorkflowStepStatus)),
                 u'title': unicode(self.ticket.title),
@@ -220,6 +223,7 @@
             u'title': unicode(self.ticket.title),
             u'bug_id': self.ticket.bug_id,
             u'owner': unicode(self.ticket.owner),
+            u'creator': unicode(self.ticket.creator),
             u'base_image': unicode(self.ticket.base_image),
             u'id': self.ticket.pk,
             u'lander_unit': 0,
@@ -445,6 +449,7 @@
             u'title': unicode(self.ticket_6.title),
             u'bug_id': self.ticket_6.bug_id,
             u'owner': unicode(self.ticket_6.owner),
+            u'creator': unicode(self.ticket_6.creator),
             u'base_image': unicode(self.ticket_6.base_image),
             u'id': self.ticket_6.pk,
             u'lander_unit': self.ticket_6.lander_unit,

=== modified file 'ticket_system/ticket/tests/test_write_api.py'
--- ticket_system/ticket/tests/test_write_api.py	2014-08-05 00:42:26 +0000
+++ ticket_system/ticket/tests/test_write_api.py	2014-08-21 13:48:34 +0000
@@ -61,6 +61,7 @@
         self.detail_url = self.resource + '{0}/'.format(self.ticket.pk)
         self.post_ticket_data = {
             'owner': '[e-mail]',
+            'creator': '[e-mail]',
             'title': 'My first ticket!',
             'description': 'This if my first ticket. See what it can do',
             'bug_id': '12345',
@@ -84,6 +85,7 @@
         a_uuid = str(uuid.uuid1())
         params = {
             'owner': '[e-mail]',
+            'creator': '[e-mail]',
             'title': 'UUID FTW!',
             'description': 'This ticket has UUID',
             'bug_id': '12345',