Merge ~jocave/plainbox-provider-tpm2:evlogdump-add-clevis into plainbox-provider-tpm2:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: a7f4c6128bbbe3a1395de76fc9060beeca3506fd
Merged at revision: 7cebe168d3e51aa2e236bea23dc2838232d989f0
Proposed branch: ~jocave/plainbox-provider-tpm2:evlogdump-add-clevis
Merge into: plainbox-provider-tpm2:master
Diff against target: 50 lines (+34/-0)
2 files modified
units/fwts.pxu (+32/-0)
units/test-plan.pxu (+2/-0)
Reviewer Review Type Date Requested Status
Maciej Kisielewski (community) Approve
Review via email: mp+406858@code.launchpad.net

Description of the change

Two commits included for these changes:

1) Create a new job to attach the TPM Event Log using fwts (include in Cert plan)

2) Also add the clevis based tests of the TPM to the Cert plan

Tested on a NewParis device.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Looks great, +1. One nitpick below.

review: Approve
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Thanks for removing the flag. +1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

Remove the 'simple' flag, rebased

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/fwts.pxu b/units/fwts.pxu
2new file mode 100644
3index 0000000..1eadca6
4--- /dev/null
5+++ b/units/fwts.pxu
6@@ -0,0 +1,32 @@
7+# This file is part of Checkbox.
8+#
9+# Copyright 2021 Canonical Ltd.
10+# Written by:
11+# Jonathan Cave <jonthan.cave@canonical.com>
12+#
13+# Checkbox is free software: you can redistribute it and/or modify
14+# it under the terms of the GNU General Public License version 3,
15+# as published by the Free Software Foundation.
16+#
17+# Checkbox is distributed in the hope that it will be useful,
18+# but WITHOUT ANY WARRANTY; without even the implied warranty of
19+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20+# GNU General Public License for more details.
21+#
22+# You should have received a copy of the GNU General Public License
23+# along with Checkbox. If not, see <http://www.gnu.org/licenses/>.
24+
25+id: tpm2/fwts-event-log-dump
26+category_id: tpm2
27+plugin: attachment
28+user: root
29+imports: from com.canonical.plainbox import manifest
30+requires:
31+ manifest.has_tpm2_chip == 'True'
32+ executable.name == 'fwts'
33+_summary: Dump the contents of the TPM Event Log
34+_description:
35+ The information in the TPM Event Log can be useful in debugging problems with
36+ TPM command support and adherance to standards. This can be of particular help
37+ when checking whether a device can support Ubuntu Core Full Disk Encryption.
38+command: fwts tpmevlogdump -r stdout
39diff --git a/units/test-plan.pxu b/units/test-plan.pxu
40index 72bc36c..b2e7f83 100644
41--- a/units/test-plan.pxu
42+++ b/units/test-plan.pxu
43@@ -120,5 +120,7 @@ _description:
44 TPM tests that should be run as part of Certification. This could be a
45 collection of tests using a variety of tools
46 include:
47+ tpm2/fwts-event-log-dump
48 nested_part:
49 tpm2.0_4.1.1-automated
50+ clevis-automated

Subscribers

People subscribed via source and target branches

to all changes: